Move weburlresponse_extradata_impl.* from webkit/ to content/.

Move weburlresponse_extradata_impl.* from webkit/ to content/.

BUG=338338
TEST=None
R=jam@chromium.org
TBR=jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284860

[jam, 2014-07-17 18:14:27]

weburlresponse_extradata_impl.* seem like internal implementation details of
content. let's hide them in content/child. You can add a method on RenderFrame
that hides this, something called "bool IsFTPDirectoryListing()" or similar.
ContentSettingObserver's IsWhitelistedForContentSettings will also have to be
changed to take a RenderFrame instead of a WebFrame

[tfarina, 2014-07-18 02:09:20]

On 2014/07/17 18:14:27, jam wrote:
> weburlresponse_extradata_impl.* seem like internal implementation details of
> content. let's hide them in content/child. You can add a method on RenderFrame
> that hides this, something called "bool IsFTPDirectoryListing()" or similar.
> ContentSettingObserver's IsWhitelistedForContentSettings will also have to be
> changed to take a RenderFrame instead of a WebFrame

Thanks John.

Done. ptal.

[tfarina, 2014-07-19 00:41:30]

John, ping??

[jam, 2014-07-21 17:16:10]

https://codereview.chromium.org/394403002/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.h (left):

https://codereview.chromium.org/394403002/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.h:117: }  // namespace blink
why change?

https://codereview.chromium.org/394403002/diff/20001/content/public/renderer/...
File content/public/renderer/render_frame.h (right):

https://codereview.chromium.org/394403002/diff/20001/content/public/renderer/...
content/public/renderer/render_frame.h:95: virtual bool
IsFTPDirectoryListing(const blink::WebURLResponse& response) = 0;
no need to pass in response, you got this in chrome-side by calling
"web_frame->dataSource()->response()", so the method should do this internally

nit: since every method here has a comment, follow that convention

https://codereview.chromium.org/394403002/diff/20001/content/renderer/DEPS
File content/renderer/DEPS (right):

https://codereview.chromium.org/394403002/diff/20001/content/renderer/DEPS#ne...
content/renderer/DEPS:2: "+content/public/child",
remove

[tfarina, 2014-07-22 01:03:03]

https://codereview.chromium.org/394403002/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.h (left):

https://codereview.chromium.org/394403002/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.h:117: }  // namespace blink
On 2014/07/21 17:16:10, jam wrote:
> why change?
base above does not have, ui below does not have. I certainly think forward
declarations like this do not need this kind of comment in the enclosing "}".
But I will revert this change, sorry for the churn.

https://codereview.chromium.org/394403002/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.h:117: }  // namespace blink
On 2014/07/21 17:16:10, jam wrote:
> why change?

Done.

https://codereview.chromium.org/394403002/diff/20001/content/public/renderer/...
File content/public/renderer/render_frame.h (right):

https://codereview.chromium.org/394403002/diff/20001/content/public/renderer/...
content/public/renderer/render_frame.h:95: virtual bool
IsFTPDirectoryListing(const blink::WebURLResponse& response) = 0;
On 2014/07/21 17:16:10, jam wrote:
> no need to pass in response, you got this in chrome-side by calling
> "web_frame->dataSource()->response()", so the method should do this internally
> 
> nit: since every method here has a comment, follow that convention

Done.

https://codereview.chromium.org/394403002/diff/20001/content/renderer/DEPS
File content/renderer/DEPS (right):

https://codereview.chromium.org/394403002/diff/20001/content/renderer/DEPS#ne...
content/renderer/DEPS:2: "+content/public/child",
On 2014/07/21 17:16:10, jam wrote:
> remove

Done.

[jam, 2014-07-22 17:09:38]

lgtm

[tfarina, 2014-07-22 22:36:25]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-07-22 22:37:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/394403002/60001

[commit-bot: I haz the power, 2014-07-23 02:33:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-23 06:27:12]

Change committed as 284860