media/base/video_rotation.h - Issue 394373002: Add VideoRotation UMA Logging

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/video_rotation.h

Issue 394373002: Add VideoRotation UMA Logging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved logging to webmediaplayer Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef MEDIA_BASE_VIDEO_ROTATION_H_	5 #ifndef MEDIA_BASE_VIDEO_ROTATION_H_

6 #define MEDIA_BASE_VIDEO_ROTATION_H_	6 #define MEDIA_BASE_VIDEO_ROTATION_H_

7	7

8 namespace media {	8 namespace media {

9	9

10 // Enumeration to represent 90 degree video rotation for MP4 videos	10 // Enumeration to represent 90 degree video rotation for MP4 videos

11 // where it can be rotated by 90 degree intervals.	11 // where it can be rotated by 90 degree intervals.
	Alexei Svitkine (slow) 2014/07/17 18:20:59 Expand comment to mention not to renumber entries Expand comment to mention not to renumber entries and only append at the end, since this is used in UMA.
12 enum VideoRotation {	12 enum VideoRotation {

13 VIDEO_ROTATION_0 = 0,	13 VIDEO_ROTATION_0 = 0,

14 VIDEO_ROTATION_90,	14 VIDEO_ROTATION_90,

15 VIDEO_ROTATION_180,	15 VIDEO_ROTATION_180,

16 VIDEO_ROTATION_270	16 VIDEO_ROTATION_270,

	17 VIDEO_ROTATION_MAX = VIDEO_ROTATION_270

17 };	18 };

18	19

19 } // namespace media	20 } // namespace media

20	21

21 #endif // MEDIA_BASE_VIDEO_ROTATION_H_	22 #endif // MEDIA_BASE_VIDEO_ROTATION_H_

OLD	NEW