Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 394353008: Fix non-components Win Debug build of extensions_unittests (Closed)

Created:
6 years, 5 months ago by hans
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Yoyo Zhou, James Cook
Project:
chromium
Visibility:
Public.

Description

Fix non-components Win Debug build of extensions_unittests It needs to depend on the allocator gyp target to pick up the /NODEFAULTLIBS flags for libcmt.lib and libcmtd.lib and avoid link errors about multiple definitions of allocation related symbols. BUG= TEST=extensions_unittests links in non-components Debug build on Win Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M extensions/extensions.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
hans
extensions_unittests started failing on the Win-Clang Dbg bot sometime last week (http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20Clang%20%28dbg%29/builds/1103/steps/compile/logs/stdio). I'm not sure ...
6 years, 5 months ago (2014-07-21 20:37:14 UTC) #1
tfarina
I don't know nothing about base/allocator so I can't say if this is correct or ...
6 years, 5 months ago (2014-07-21 23:03:20 UTC) #2
not at google - send to devlin
Hopefully either jyasskin or yoz can say something informed.
6 years, 5 months ago (2014-07-21 23:10:20 UTC) #3
Yoyo Zhou
I'm not familiar with base/allocator either. =( However, I see this pattern all over our ...
6 years, 5 months ago (2014-07-21 23:34:57 UTC) #4
hans
The CQ bit was checked by hans@chromium.org
6 years, 5 months ago (2014-07-21 23:36:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/394353008/1
6 years, 5 months ago (2014-07-21 23:37:51 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 02:51:15 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 03:27:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173312)
6 years, 5 months ago (2014-07-22 03:27:44 UTC) #9
hans
The CQ bit was checked by hans@chromium.org
6 years, 5 months ago (2014-07-22 03:56:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/394353008/1
6 years, 5 months ago (2014-07-22 03:57:07 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 05:10:13 UTC) #12
Message was sent while issue was closed.
Change committed as 284632

Powered by Google App Engine
This is Rietveld 408576698