Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 394303002: roll common DEPS, and start using recursedeps (Closed)

Created:
6 years, 5 months ago by epoger
Modified:
6 years, 5 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

roll common DEPS, and start using recursedeps None of the buildbot code imports gs_utils.py from common yet, but now it *can*. BUG=skia:2618 Committed: https://skia.googlesource.com/buildbot/+/f0ec6c786f940344fd4192db1b6d03fa0343f367

Patch Set 1 #

Patch Set 2 : update reference to misc.GitBranch #

Patch Set 3 : use list instead of set for recursedeps #

Total comments: 1

Patch Set 4 : modify TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M DEPS View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M slave/skia_slave_scripts/update_skp_version.py View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
epoger
Eric- please review at patchset 1. To test, I am running a test buildbot master ...
6 years, 5 months ago (2014-07-16 20:40:24 UTC) #1
borenet
On 2014/07/16 20:40:24, epoger wrote: > Eric- please review at patchset 1. > > To ...
6 years, 5 months ago (2014-07-16 20:50:07 UTC) #2
epoger
Thanks, Eric; please see patchsets 2+3.
6 years, 5 months ago (2014-07-16 21:06:04 UTC) #3
borenet
LGTM https://codereview.chromium.org/394303002/diff/40001/DEPS File DEPS (right): https://codereview.chromium.org/394303002/diff/40001/DEPS#newcode73 DEPS:73: # TODO(borenet): Maybe use recursedeps for these? Good ...
6 years, 5 months ago (2014-07-16 21:08:36 UTC) #4
epoger
The CQ bit was checked by epoger@google.com
6 years, 5 months ago (2014-07-16 21:13:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/394303002/60001
6 years, 5 months ago (2014-07-16 21:14:28 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 21:15:13 UTC) #7
Message was sent while issue was closed.
Change committed as f0ec6c786f940344fd4192db1b6d03fa0343f367

Powered by Google App Engine
This is Rietveld 408576698