sync/internal_api/attachments/attachment_uploader_impl.cc - Issue 394293003: Do not update AttachmentIds after uploading attachments to sync server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/attachment_uploader_impl.cc

Issue 394293003: Do not update AttachmentIds after uploading attachments to sync server. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/api/attachments/attachment_uploader.h ('k') | sync/internal_api/attachments/attachment_uploader_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/attachments/attachment_uploader_impl.cc

diff --git a/sync/internal_api/attachments/attachment_uploader_impl.cc b/sync/internal_api/attachments/attachment_uploader_impl.cc

index 7e1235013b7939ab5aec67d66d4954e2d81a351e..c2bda36f8b8e9402df4276a434b2ffcf55fffad9 100644

--- a/sync/internal_api/attachments/attachment_uploader_impl.cc

+++ b/sync/internal_api/attachments/attachment_uploader_impl.cc

@@ -137,8 +137,6 @@ void AttachmentUploaderImpl::UploadState::OnURLFetchComplete(

AttachmentId attachment_id = attachment_.GetId();

if (source->GetResponseCode() == net::HTTP_OK) {

result = UPLOAD_SUCCESS;

- // TODO(maniscalco): Update the attachment id with server address

- // information before passing it to the callback (bug 371522).

} else if (source->GetResponseCode() == net::HTTP_UNAUTHORIZED) {

// TODO(maniscalco): One possibility is that we received a 401 because our

// access token has expired. We should probably fetch a new access token

« no previous file with comments | « sync/api/attachments/attachment_uploader.h ('k') | sync/internal_api/attachments/attachment_uploader_impl_unittest.cc » ('j') | no next file with comments »