components/sync_driver/generic_change_processor.cc - Issue 394293003: Do not update AttachmentIds after uploading attachments to sync server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/generic_change_processor.cc

Issue 394293003: Do not update AttachmentIds after uploading attachments to sync server. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/sync_driver/generic_change_processor.cc

diff --git a/components/sync_driver/generic_change_processor.cc b/components/sync_driver/generic_change_processor.cc

index 7917edc28a7f50ec4364dfc6c506119650ea7045..4cd943ce84530c79f6cf8e3a8affa07fb4d7307f 100644

--- a/components/sync_driver/generic_change_processor.cc

+++ b/components/sync_driver/generic_change_processor.cc

@@ -214,7 +214,7 @@ syncer::SyncError GenericChangeProcessor::UpdateDataTypeContext(

void GenericChangeProcessor::OnAttachmentUploaded(

const syncer::AttachmentId& attachment_id) {

syncer::WriteTransaction trans(FROM_HERE, share_handle());

- trans.UpdateEntriesWithAttachmentId(attachment_id);

+ trans.UpdateEntriesMarkAttachmentAsOnServer(attachment_id);

}

syncer::SyncError GenericChangeProcessor::GetAllSyncDataReturnError(

« no previous file with comments | « no previous file | sync/api/attachments/attachment_uploader.h » ('j') | no next file with comments »