Do not update AttachmentIds after uploading attachments to sync server.

sync/syncable/directory_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/syncable/directory_unittest.h"
 
 #include "base/strings/stringprintf.h"
 #include "base/test/values_test_util.h"
 #include "sync/internal_api/public/base/attachment_id_proto.h"
 #include "sync/syncable/syncable_proto_util.h"
@@ skipping 1631 matching lines @@
   entry.PutId(TestIdFactory::FromNumber(-1));
   entry.PutAttachmentMetadata(attachment_metadata);
 
   const sync_pb::AttachmentMetadata& entry_metadata =
       entry.GetAttachmentMetadata();
   ASSERT_EQ(2, entry_metadata.record_size());
   ASSERT_FALSE(entry_metadata.record(0).is_on_server());
   ASSERT_FALSE(entry_metadata.record(1).is_on_server());
   ASSERT_FALSE(entry.GetIsUnsynced());
 
-  // TODO(pavely): When we add server info to proto, add test for it here.
-  entry.UpdateAttachmentIdWithServerInfo(attachment_id_proto);
+  entry.MarkAttachmentAsOnServer(attachment_id_proto);
 
   ASSERT_TRUE(entry_metadata.record(0).is_on_server());
   ASSERT_FALSE(entry_metadata.record(1).is_on_server());
   ASSERT_TRUE(entry.GetIsUnsynced());
 }
 
 // Verify that deleted entries with attachments will retain the attachments.
 TEST_F(SyncableDirectoryTest, Directory_DeleteDoesNotUnlinkAttachments) {
   sync_pb::AttachmentMetadata attachment_metadata;
   sync_pb::AttachmentMetadataRecord* record = attachment_metadata.add_record();
@@ skipping 50 matching lines @@
   // Delete the second entry, reload the Directory, see that the attachment is
   // no loner linked.
   DeleteEntry(id2);
   SimulateSaveAndReloadDir();
   ASSERT_FALSE(dir()->IsAttachmentLinked(attachment_id_proto));
 }
 
 }  // namespace syncable
 
 }  // namespace syncer