Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 394223003: skia_directwrite -> skia_gdi (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

skia_directwrite -> skia_gdi This will require lots of rebaselines and a bot CL to swap our lone direct write bot to a lone GDI bot. BUG=skia: R=bungeman@google.com Committed: https://skia.googlesource.com/skia/+/9358706

Patch Set 1 #

Patch Set 2 : skia_gdi instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M gyp/common_variables.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M gyp/ports.gyp View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 5 months ago (2014-07-16 16:10:51 UTC) #1
bungeman-skia
lgtm, and may the rebaseline be with you.
6 years, 5 months ago (2014-07-16 17:04:29 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-16 17:04:40 UTC) #3
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 5 months ago (2014-07-16 17:04:41 UTC) #4
mtklein_C
6 years, 5 months ago (2014-07-16 17:06:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r9358706.

Powered by Google App Engine
This is Rietveld 408576698