chrome/browser/sync/sessions/session_data_type_controller_unittest.cc - Issue 394223002: Disable tab syncing when history saving is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

Issue 394223002: Disable tab syncing when history saving is disabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/sessions/session_data_type_controller.cc ('K') | « chrome/browser/sync/sessions/session_data_type_controller.cc ('k') | chrome/browser/sync/test/integration/sync_errors_test.cc » ('j') | components/policy/resources/policy_templates.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

diff --git a/chrome/browser/sync/sessions/session_data_type_controller_unittest.cc b/chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

index 50448032ff5b67f388c1dd9053d5a6dbdccae28f..3a80d0086b31e76315980ad399cb96c38b26b282 100644

--- a/chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

+++ b/chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

@@ -118,7 +118,9 @@ class SessionDataTypeControllerTest

}

void Start() {

- controller_->LoadModels(

+ // Upcast to use protected method.

+ sync_driver::UIDataTypeController* controller = controller_;

Andrew T Wilson (Slow) 2014/08/21 14:10:38 Remove this.

Joao da Silva 2014/08/26 16:06:52 Done.

+ controller->LoadModels(

base::Bind(&SessionDataTypeControllerTest::OnLoadFinished,

weak_ptr_factory_.GetWeakPtr()));

}