Issue 394203002: GLHelper: validate destination size matches last scale size in test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 394203002: GLHelper: validate destination size matches last scale size in test (Closed)

Created:
6 years, 5 months ago by robert.bradford

Modified:
6 years, 5 months ago

Reviewers:
piman

CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, hubbe

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

GLHelper: validate destination size matches last scale size In the GLHelper unittest the ValidateScalerStages function checks that the scaling stages to be executed for the scale are valid. This change also adds a check to ensure that the size of the destination texture matches the destination size in the last stage of the scaler pipeline. This identified some of the test cases had small errors in the destination sizes which didn't match the description of the scale. The patch also corrects those. TEST=content_gl_tests passes BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283710