Tiling priorities in Android Webview.

android_webview/browser/hardware_renderer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/hardware_renderer.h"
 
 #include "android_webview/browser/aw_gl_surface.h"
 #include "android_webview/browser/deferred_gpu_command_service.h"
 #include "android_webview/browser/parent_output_surface.h"
 #include "android_webview/browser/shared_renderer_state.h"
@@ skipping 170 matching lines @@
       delegated_layer_->SetIsDrawable(true);
 
       root_layer_->AddChild(delegated_layer_);
     } else {
       frame_provider_->SetFrameData(input->frame.delegated_frame_data.Pass());
     }
   }
 
   viewport_.SetSize(draw_info->width, draw_info->height);
   layer_tree_host_->SetViewportSize(viewport_);
-  clip_.SetRect(draw_info->clip_left,
-                draw_info->clip_top,
-                draw_info->clip_right - draw_info->clip_left,
-                draw_info->clip_bottom - draw_info->clip_top);
+  gfx::Rect clip(draw_info->clip_left,
+                 draw_info->clip_top,
+                 draw_info->clip_right - draw_info->clip_left,
+                 draw_info->clip_bottom - draw_info->clip_top);
   stencil_enabled_ = stencil_enabled;
 
   gfx::Transform transform(gfx::Transform::kSkipInitialization);
   transform.matrix().setColMajorf(draw_info->transform);
   transform.Translate(scroll_offset_.x(), scroll_offset_.y());
   delegated_layer_->SetTransform(transform);
 
   gl_surface_->SetBackingFrameBufferObject(framebuffer_binding_ext);
   {
     base::AutoReset<bool> frame_resetter(&viewport_clip_valid_for_dcheck_,
                                          true);
-    layer_tree_host_->SetNeedsRedrawRect(clip_);
+    layer_tree_host_->SetNeedsRedrawRect(clip);
     layer_tree_host_->Composite(gfx::FrameTime::Now());
   }
   gl_surface_->ResetBackingFrameBufferObject();
+
+  // Need to post the new transform matrix and clip back to child compositor
+  // because there is no onDraw during a Render Thread animation, and child
+  // compositor might not have the tiles rasterized as the animation goes on.
+  if (transform != transform_ || clip != clip_) {
+    transform_ = transform;
+    clip_ = clip;

[boliu, 2014/07/16 17:25:10]

child shouldn't need the clip, clip isn't suitable for tile management since it
can jump around wildly

[hush (inactive), 2014/07/16 20:45:32]

okay.
I also change the function name to PostExternalMatrixToChildCompositor.

On 2014/07/16 17:25:10, boliu wrote:

+    shared_renderer_state_->PostExternalDrawConstraintsToChildCompositor(
+        clip_, transform_);
+  }
 }
 
 scoped_ptr<cc::OutputSurface> HardwareRenderer::CreateOutputSurface(
     bool fallback) {
   // Android webview does not support losing output surface.
   DCHECK(!fallback);
   scoped_refptr<cc::ContextProvider> context_provider =
       CreateContext(gl_surface_,
                     DeferredGpuCommandService::GetInstance(),
                     shared_renderer_state_->GetSharedContext());
   scoped_ptr<ParentOutputSurface> output_surface_holder(
       new ParentOutputSurface(context_provider));
   output_surface_ = output_surface_holder.get();
   return output_surface_holder.PassAs<cc::OutputSurface>();
 }
 
 void HardwareRenderer::UnusedResourcesAreAvailable() {
   cc::ReturnedResourceArray returned_resources;
   resource_collection_->TakeUnusedResourcesForChildCompositor(
       &returned_resources);
   shared_renderer_state_->InsertReturnedResources(returned_resources);
 }
 
 }  // namespace android_webview