Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: android_webview/browser/parent_compositor_draw_constraints.cc

Issue 394113002: Tiling priorities in Android Webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added a unit test for PictureLayerImpl Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "android_webview/browser/parent_compositor_draw_constraints.h"
6
7 namespace android_webview {
8
9 ParentCompositorDrawConstraints::ParentCompositorDrawConstraints()
10 : is_layer(false), transform(gfx::Transform()), surface_rect(gfx::Rect()) {
boliu 2014/07/29 19:02:41 Transform and Rect have default constructors
hush (inactive) 2014/07/29 21:14:21 okay. Removed. On 2014/07/29 19:02:41, boliu wrote
11 }
12
13 ParentCompositorDrawConstraints::ParentCompositorDrawConstraints(
14 bool is_layer,
15 gfx::Transform transform,
16 gfx::Rect surface_rect) {
17 this->is_layer = is_layer;
18 this->transform = transform;
19 this->surface_rect = surface_rect;
boliu 2014/07/29 19:02:41 Use initializer list. Otherwise why have this cons
hush (inactive) 2014/07/29 21:14:21 used initializer list. On 2014/07/29 19:02:41, bol
20 }
21
22 bool ParentCompositorDrawConstraints::equals(
23 ParentCompositorDrawConstraints other) const {
24 return is_layer == other.is_layer && transform == other.transform &&
25 surface_rect == other.surface_rect;
26 }
27
28 } // namespace webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698