Tiling priorities in Android Webview.

cc/output/output_surface.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_OUTPUT_OUTPUT_SURFACE_H_
 #define CC_OUTPUT_OUTPUT_SURFACE_H_
 
 #include <deque>
 
 #include "base/basictypes.h"
@@ skipping 145 matching lines @@
   gfx::Size surface_size_;
   float device_scale_factor_;
 
   void CommitVSyncParameters(base::TimeTicks timebase,
                              base::TimeDelta interval);
 
   void SetNeedsRedrawRect(const gfx::Rect& damage_rect);
   void ReclaimResources(const CompositorFrameAck* ack);
   void DidLoseOutputSurface();
   void SetExternalStencilTest(bool enabled);
-  void SetExternalDrawConstraints(const gfx::Transform& transform,
-                                  const gfx::Rect& viewport,
-                                  const gfx::Rect& clip,
-                                  bool resourceless_software_draw);
+  void SetExternalDrawConstraints(
+      const gfx::Transform& transform,
+      const gfx::Rect& viewport,
+      const gfx::Rect& clip,
+      const gfx::Rect& external_tiling_rect,

[enne (OOO), 2014/07/25 19:16:55]

In general this patch looks fine to me, but I still am bikeshedding a little on
external_tiling_rect and external_tiling_transform as names.  The name "tiling"
just doesn't really mean anything and is ambiguous with other uses of "tiling"
in cc.

Are there other names that could work here? One suggestion:
external_viewport_rect and external_viewport_transform make slightly more sense
to me.  "external" because they're not applied to quads in the same way that
transform/viewport in this function are?

Maybe a comment on this function about how these two parameters differ from
transform/viewport would help too?

[hush (inactive), 2014/07/29 00:55:57]

This function name actually suggests all parameters are "external" implicitly.
For example, transform is stored as "external_transform_" in
LTHI::SetExternalDrawConstraints.

So how about I make it verbose and consistent with what we use in
picture_layer_impl: viewport_rect_for_tile_priority and
transform_for_tile_priority

There are already comments in LTHI private members (external_transform_, 
external_viewport, etc.). Are those comments enough?

On 2014/07/25 19:16:55, enne wrote:

[enne (OOO), 2014/07/29 18:39:28]

"_for_tile_priority" is definitely better than "tiling", thanks.  And
consistency in variable naming all the way through also seems good.

Those comments are probably enough.

+      const gfx::Transform& external_tiling_transform,
+      bool resourceless_software_draw);
 
  private:
   void SetUpContext3d();
   void ResetContext3d();
   void SetMemoryPolicy(const ManagedMemoryPolicy& policy);
 
   bool external_stencil_test_enabled_;
 
   base::WeakPtrFactory<OutputSurface> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OutputSurface);
 };
 
 }  // namespace cc
 
 #endif  // CC_OUTPUT_OUTPUT_SURFACE_H_