Add unit tests for drive::FileTaskExecutor.

Add unit tests for drive::FileTaskExecutor.

The tests verify that FileTaskExecutor indeed performs the intended
interaction with the Drive file system and the remote server to obtain
an authenticated URL, and tries to open the link.

BUG=161209
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283711

[kinaba, 2014-07-16 01:25:06]

PTAL. It depends on https://codereview.chromium.org/391003006/.

[hirono, 2014-07-16 04:33:20]

lgtm with nits. Thanks!

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/file_task_executor_unittest.cc (right):

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:83:
std::set<std::string>* opend_urls_;
nit: std::set<std::string>* const

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:96: TestDelegate*
delegate_ptr = new TestDelegate(&opend_urls);
nit: TestDelegate* const

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:99:
FileTaskExecutor* executor = new FileTaskExecutor(
nit: FileTaskExecutor* const

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:112:
extensions::api::file_browser_private::TaskResult result =
nit: const

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:130: TestDelegate*
delegate_ptr = new TestDelegate(&opend_urls);
ditto.

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:133:
FileTaskExecutor* executor = new FileTaskExecutor(
ditto.

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:142:
extensions::api::file_browser_private::TaskResult result =
ditto

[kinaba, 2014-07-16 04:40:27]

thx

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/file_task_executor_unittest.cc (right):

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:83:
std::set<std::string>* opend_urls_;
On 2014/07/16 04:33:19, hirono wrote:
> nit: std::set<std::string>* const

Done.

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:96: TestDelegate*
delegate_ptr = new TestDelegate(&opend_urls);
On 2014/07/16 04:33:20, hirono wrote:
> nit: TestDelegate* const

Done.

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:99:
FileTaskExecutor* executor = new FileTaskExecutor(
On 2014/07/16 04:33:19, hirono wrote:
> nit: FileTaskExecutor* const

Done.

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:112:
extensions::api::file_browser_private::TaskResult result =
On 2014/07/16 04:33:19, hirono wrote:
> nit: const

This is to be modified in CreateCopyResultCallback

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:130: TestDelegate*
delegate_ptr = new TestDelegate(&opend_urls);
On 2014/07/16 04:33:19, hirono wrote:
> ditto.

Done.

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:133:
FileTaskExecutor* executor = new FileTaskExecutor(
On 2014/07/16 04:33:19, hirono wrote:
> ditto.

Done.

https://codereview.chromium.org/394103003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/file_task_executor_unittest.cc:142:
extensions::api::file_browser_private::TaskResult result =
On 2014/07/16 04:33:19, hirono wrote:
> ditto

ditto (it has to be mutable.)

[kinaba, 2014-07-16 23:40:51]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-07-16 23:43:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/394103003/40001

[commit-bot: I haz the power, 2014-07-17 08:26:07]

Change committed as 283711