Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: components/metrics.gypi

Issue 394093003: Moves components/metrics/chromeos to c/m/serialization/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/components_tests.gyp ('k') | components/metrics/chromeos/metric_sample.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics.gypi
diff --git a/components/metrics.gypi b/components/metrics.gypi
index f3dc749d0f89766fbe4769935a2fa175deb3897d..e52a1711e17611ce3acf3dcea6abb8300b3bfe55 100644
--- a/components/metrics.gypi
+++ b/components/metrics.gypi
@@ -53,7 +53,7 @@
'conditions': [
['chromeos==1', {
'dependencies': [
- 'metrics_chromeos',
+ 'metrics_external_utils',
],
}],
['OS=="win"', {
@@ -123,24 +123,18 @@
'metrics/test_metrics_service_client.h',
],
},
- ],
- 'conditions': [
- ['chromeos==1', {
- 'targets': [
- {
- 'target_name': 'metrics_chromeos',
- 'type': 'static_library',
- 'sources': [
- 'metrics/chromeos/serialization_utils.cc',
- 'metrics/chromeos/serialization_utils.h',
- 'metrics/chromeos/metric_sample.cc',
- 'metrics/chromeos/metric_sample.h',
- ],
- 'dependencies': [
- '../base/base.gyp:base',
- ],
- },
+ {
+ 'target_name': 'metrics_external_utils',
Ilya Sherman 2014/07/16 03:31:46 nit: This should probably be named "metrics_extern
+ 'type': 'static_library',
+ 'sources': [
+ 'metrics/external/serialization_utils.cc',
+ 'metrics/external/serialization_utils.h',
+ 'metrics/external/metric_sample.cc',
+ 'metrics/external/metric_sample.h',
],
- }],
+ 'dependencies': [
+ '../base/base.gyp:base',
+ ],
+ },
],
}
« no previous file with comments | « components/components_tests.gyp ('k') | components/metrics/chromeos/metric_sample.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698