Moves components/metrics/chromeos to c/m/serialization/.

Moves components/metrics/chromeos to c/m/serialization/.

This allows other clients to use the external serialization utils.

R=bsimonnet@chromium.org,isherman@chromium.org,asvitkine@chromium.org
BUG=343624
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283880

[Ilya Sherman, 2014-07-16 03:31:46]

+Dr. Blundell

Is there a general plan for sharing more code between ChromeOS and ChromeCast? 
It would be nice to structure this change in alignment with a more broadly
thought-out plan, if there is one.  Bertrand, perhaps you have some insight?

https://codereview.chromium.org/394093003/diff/1/components/metrics.gypi
File components/metrics.gypi (right):

https://codereview.chromium.org/394093003/diff/1/components/metrics.gypi#newc...
components/metrics.gypi:127: 'target_name': 'metrics_external_utils',
nit: This should probably be named "metrics_external", to match the directory
name.

[Ilya Sherman, 2014-07-16 03:32:22]

Also, are there BUILD.gn files that should be updated as well?

[blundell, 2014-07-16 08:34:28]

The approach taken in this CL seems like the right one to me at a high level.
However, I'm not really sold on "external"; that name doesn't convey anything to
my mind.

[Alexei Svitkine (slow), 2014-07-16 13:06:57]

Agreed, I'd like to see a doc outlining the overall plan for this.

As for naming, I'd name the directory by its function - e.g. serialization.
Then, platforms that need it can depend on the target while other platforms can
ignore it.

[bsimonnet, 2014-07-16 14:56:06]

On 2014/07/16 13:06:57, Alexei Svitkine wrote:
> Agreed, I'd like to see a doc outlining the overall plan for this.
> 
> As for naming, I'd name the directory by its function - e.g. serialization.
> Then, platforms that need it can depend on the target while other platforms
can
> ignore it.

This is fine from a ChromeOS point of view.
isherman@, we have a long term plan to share code between Chrome cast and Chrome
OS but I don't think it is a priority right now. The Chrome interface to send
metrics can be used by anyone but the metrics daemon in Chromeos is probably
harder to integrate.

[gunsch, 2014-07-16 17:08:23]

Thanks everyone for the thoughts so far. PTAL.

Some quick notes:
* Bertrand and I chatted briefly about this a couple months ago, shortly before
the MetricsService refactoring. That was the bulk of what Chromecast was looking
to have separated.
* Chromecast has been using ChromeOS's libmetrics for some time already.
However, on the Chrome side (ExternalMetrics) it was sort of just hacked in
before.
* Given that, as far as a long-term plan/doc, I don't actually see much in terms
of plans past this CL. I can write up more about what we have if that's
interesting to everyone here and seems worth the time to do so.
* The existing "ExternalMetrics" class
(chrome/browser/chromeos/external_metrics.*) could be refactored out somewhat,
but half of the code in there is ChromeOS-specific anyways. The serialization
utils are the bulk of the shared code.

I'm not attached to the "external" name at all, So I've taken the
"serialization" suggestion and updated the CL.

There are no BUILD.gn files that need to be updated. It appears the
metrics_chromeos GN target hadn't yet been created.

[Ilya Sherman, 2014-07-16 17:32:25]

LGTM, thanks.

[gunsch, 2014-07-16 21:13:38]

+stevenjb for chrome/browser/chromeos OWNERS

[stevenjb, 2014-07-16 21:19:52]

c/b/chromeos lgtm

[gunsch, 2014-07-16 22:28:51]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-07-16 22:35:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gunsch@chromium.org/394093003/20001

[commit-bot: I haz the power, 2014-07-17 02:42:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-17 02:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 02:45:45]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[gunsch, 2014-07-17 03:36:39]

FYI: all the non-Linux tests failed; the implementation of SerializationUtils is
pretty tied to low-level Linux file calls. For the meantime, I re-added the
target restriction, but only with OS=="linux" instead of the tighter
chromeos==1. PTAL if interested.

[gunsch, 2014-07-17 17:48:00]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:50:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gunsch@chromium.org/394093003/40001

[commit-bot: I haz the power, 2014-07-17 21:19:41]

Change committed as 283880