Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 394093002: Fix for CRD webapp to install the host when it's not installed and Share is cliecked (Closed)

Created:
6 years, 5 months ago by Sergey Ulanov
Modified:
6 years, 5 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix for CRD webapp to install the host when it's not installed and Share is cliecked This was a regression caused by crrev.com/279513 BUG=393388 R=jamiewalch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M remoting/webapp/host_screen.js View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Sergey Ulanov
6 years, 5 months ago (2014-07-15 23:36:41 UTC) #1
Sergey Ulanov
Do we have a bug for this problem?
6 years, 5 months ago (2014-07-15 23:38:27 UTC) #2
Jamie
LGTM. No bug for this problem specifically, no, although you could include it as part ...
6 years, 5 months ago (2014-07-16 00:17:25 UTC) #3
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-16 00:33:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/394093002/1
6 years, 5 months ago (2014-07-16 00:36:23 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 08:55:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 09:17:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171241)
6 years, 5 months ago (2014-07-16 09:17:06 UTC) #8
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-16 17:39:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/394093002/1
6 years, 5 months ago (2014-07-16 17:42:47 UTC) #10
Sergey Ulanov
6 years, 5 months ago (2014-07-16 18:01:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 manually as r283423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698