athena/wm/DEPS - Issue 394043002: athena: Add a minimized state for the home-card.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: athena/wm/DEPS

Issue 394043002: athena: Add a minimized state for the home-card. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: self-nits Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+athena/home/public",
	Jun Mukai 2014/07/16 05:53:58 I think it's better to avoid the mutual dependenci I think it's better to avoid the mutual dependencies among athena directories. The usage in athena/wm is really simple. Can we: - add some observer, like OverviewModeObserver - Let HomeCardImpl to set its status by itself oshima 2014/07/16 16:24:31 Yep, no circular dependency. Let's have a WindowMa Show quoted text On 2014/07/16 05:53:58, Jun Mukai wrote: > I think it's better to avoid the mutual dependencies among athena directories. > > The usage in athena/wm is really simple. Can we: > - add some observer, like OverviewModeObserver > - Let HomeCardImpl to set its status by itself Yep, no circular dependency. Let's have a WindowManagerObserver::OnOverviewModeChanged. sadrul 2014/07/16 16:58:26 Good idea. Thanks! Done. In keeping with the ash s Show quoted text On 2014/07/16 16:24:31, oshima wrote: > On 2014/07/16 05:53:58, Jun Mukai wrote: > > I think it's better to avoid the mutual dependencies among athena directories. > > > > The usage in athena/wm is really simple. Can we: > > - add some observer, like OverviewModeObserver > > - Let HomeCardImpl to set its status by itself > > Yep, no circular dependency. Let's have a > WindowManagerObserver::OnOverviewModeChanged. Good idea. Thanks! Done. In keeping with the ash style, added OnOverviewModeEnter and OnOverviewModeExit
2 "+athena/screen/public",	3 "+athena/screen/public",

3 "+ui/aura",	4 "+ui/aura",

4 "+ui/compositor",	5 "+ui/compositor",

5 "+ui/events",	6 "+ui/events",

6 "+ui/gfx",	7 "+ui/gfx",

7 "+ui/wm",	8 "+ui/wm",

8 ]	9 ]

OLD	NEW

« athena/home/home_card_impl.cc ('K') | « athena/home/public/home_card.h ('k') | athena/wm/public/window_manager.h » ('j') | no next file with comments »