[SyncFS] Make the snapshot sync of local-to-remote sync parallelization enabled. (2/3)

[SyncFS] Make the snapshot sync of local-to-remote sync parallelization enabled.

Support snapshot-sync on demoted URL.
Previous implementation drops changes in demoted changes, and doesn't mirror new changes on demoted URLs.

BUG=344769
TEST=unit_tests --gtest_filter="LocalFileChangeTrackerTest.*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285335

[tzik, 2014-07-22 10:08:08]

PTL

[peria, 2014-07-23 01:52:01]

lgtm

please fill BUG and TEST lines in the description before submitting.

[nhiroki, 2014-07-23 06:37:13]

lgtm

https://codereview.chromium.org/394033005/diff/80001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/local/local_file_change_tracker.cc (right):

https://codereview.chromium.org/394033005/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/local/local_file_change_tracker.cc:413: int
change_seq = current_change_seq_++;
(Option) Since |current_change_seq_| is confusing with |change_seq_| (NOT
|change_seq|), how about renaming it to |current_change_seq_number_| or
something?

https://codereview.chromium.org/394033005/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/local/local_file_change_tracker.cc:417: } else{
nit: please add a space after 'else'.

https://codereview.chromium.org/394033005/diff/100001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/local/local_file_change_tracker.cc (right):

https://codereview.chromium.org/394033005/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/local/local_file_change_tracker.cc:205: if
(ContainsKey(demoted_changes_, url)) {
Can you have "DCHECK(!ContainsKey(changes_, url))"?

https://codereview.chromium.org/394033005/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/local/local_file_change_tracker.cc:207: } else {
ditto: "DCHECK(!ContainsKey(demoted_changes_, url))"?

[tzik, 2014-07-24 15:35:20]

https://codereview.chromium.org/394033005/diff/80001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/local/local_file_change_tracker.cc (right):

https://codereview.chromium.org/394033005/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/local/local_file_change_tracker.cc:413: int
change_seq = current_change_seq_++;
On 2014/07/23 06:37:13, nhiroki wrote:
> (Option) Since |current_change_seq_| is confusing with |change_seq_| (NOT
> |change_seq|), how about renaming it to |current_change_seq_number_| or
> something?

Done.

https://codereview.chromium.org/394033005/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/local/local_file_change_tracker.cc:417: } else{
On 2014/07/23 06:37:12, nhiroki wrote:
> nit: please add a space after 'else'.

Done.

https://codereview.chromium.org/394033005/diff/100001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/local/local_file_change_tracker.cc (right):

https://codereview.chromium.org/394033005/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/local/local_file_change_tracker.cc:205: if
(ContainsKey(demoted_changes_, url)) {
On 2014/07/23 06:37:13, nhiroki wrote:
> Can you have "DCHECK(!ContainsKey(changes_, url))"?

Done.

https://codereview.chromium.org/394033005/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/local/local_file_change_tracker.cc:207: } else {
On 2014/07/23 06:37:13, nhiroki wrote:
> ditto: "DCHECK(!ContainsKey(demoted_changes_, url))"?

Done.

[tzik, 2014-07-24 15:36:38]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-07-24 15:37:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/394033005/120001

[commit-bot: I haz the power, 2014-07-24 18:28:02]

Change committed as 285335