Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: chrome/browser/BUILD.gn

Issue 394033002: Add gcm, nfc and bluetooth to GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index b346fe3c873ef12dfa076cb30669f0979da4a905..94928a1af29e847144e411aea02bc7c216ce4d62 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -38,6 +38,7 @@ static_library("browser") {
"//chrome/browser/net:cert_logger_proto",
"//chrome/browser/net:probe_message_proto",
"//chrome/browser/search/suggestions/proto",
+ "//chrome/browser/ui",
"//chrome/common",
"//chrome/common/net",
"//components/autocomplete",
@@ -48,6 +49,8 @@ static_library("browser") {
"//components/domain_reliability",
"//components/favicon_base",
"//components/favicon/core",
+ "//components/feedback",
+ "//components/gcm_driver",
"//components/history/core/browser",
"//components/history/core/common",
"//components/metrics:net",
@@ -56,6 +59,8 @@ static_library("browser") {
"//components/policy:policy_component",
"//components/query_parser",
"//components/rappor",
+ "//components/signin/core/browser",
+ "//components/startup_metric_utils",
"//components/strings",
"//components/translate/core/browser",
"//components/translate/core/common",
@@ -84,10 +89,7 @@ static_library("browser") {
"//ui/strings",
"//ui/resources",
# TODO(GYP)
- #"browser_ui",
#"../components/components.gyp:bookmarks_browser",
- #"../components/components.gyp:feedback_component",
- #"../components/components.gyp:gcm_driver",
#"../components/components.gyp:google_core_browser",
#"../components/components.gyp:infobars_core",
#"../components/components.gyp:invalidation",
@@ -98,8 +100,6 @@ static_library("browser") {
#"../components/components.gyp:precache_core",
#"../components/components.gyp:search_engines",
#"../components/components.gyp:search_provider_logos",
- #"../components/components.gyp:signin_core_browser",
- #"../components/components.gyp:startup_metric_utils",
#"../components/components.gyp:sync_driver",
#"../jingle/jingle.gyp:notifier",
#"../third_party/libjingle/libjingle.gyp:libjingle",
@@ -143,6 +143,7 @@ static_library("browser") {
"//components/autofill/content/browser",
"//components/dom_distiller/content",
"//components/keyed_service/content",
+ "//components/storage_monitor",
"//components/translate/content/browser",
"//components/url_matcher",
"//components/usb_service",
@@ -178,7 +179,6 @@ static_library("browser") {
#"../components/components.gyp:password_manager_content_browser",
#"../components/components.gyp:precache_content",
#"../components/components.gyp:sessions",
- #"../components/components.gyp:storage_monitor",
#"../media/cast/cast.gyp:cast_transport",
#"../media/media.gyp:media",
## TODO(tonyg): Remove this dependency (crbug.com/280157).
@@ -455,10 +455,10 @@ static_library("browser") {
]
deps -= [
"//third_party/libaddressinput",
- #"../components/components.gyp:feedback_component", TODO(GYP)
- #"../components/components.gyp:storage_monitor", TODO(GYP)
- #"../components/components.gyp:usb_service", TODO(GYP)
- #"../components/components.gyp:web_modal", TODO(GYP)
+ "//components/feedback",
+ "//components/storage_monitor",
+ "//components/usb_service",
+ "//components/web_modal",
]
} else {
sources += rebase_path(gypi_values.chrome_browser_non_android_sources,
« no previous file with comments | « BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698