Issue 394033002: Add gcm, nfc and bluetooth to GN build.

Issue 394033002: Add gcm, nfc and bluetooth to GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
jamesr

CC:
chromium-reviews, zea+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add gcm, nfc and bluetooth to GN build. TBR=jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283486

Patch Set 4 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+557 lines, -21 lines)			Patch
M	BUILD.gn	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/BUILD.gn	View	1 2	8 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/BUILD.gn	View	1 2	4 chunks	+3 lines, -3 lines	0 comments	Download
M	components/BUILD.gn	View	1 2	4 chunks	+4 lines, -0 lines	0 comments	Download
M	components/gcm_driver.gypi	View		4 chunks	+4 lines, -0 lines	0 comments	Download
A	components/gcm_driver/BUILD.gn	View		1 chunk	+86 lines, -0 lines	0 comments	Download
M	components/signin.gypi	View		7 chunks	+7 lines, -0 lines	0 comments	Download
A	components/signin/core/browser/BUILD.gn	View		1 chunk	+85 lines, -0 lines	0 comments	Download
A +	components/signin/core/common/BUILD.gn	View		1 chunk	+6 lines, -6 lines	0 comments	Download
A	components/signin/ios/browser/BUILD.gn	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	device/bluetooth/BUILD.gn	View		1 chunk	+150 lines, -0 lines	0 comments	Download
M	device/bluetooth/bluetooth.gyp	View		4 chunks	+4 lines, -0 lines	0 comments	Download
A	device/nfc/BUILD.gn	View		1 chunk	+42 lines, -0 lines	0 comments	Download
M	device/nfc/nfc.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	google_apis/gcm/BUILD.gn	View		1 chunk	+127 lines, -0 lines	0 comments	Download
M	google_apis/gcm/gcm.gyp	View		7 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

https://codereview.chromium.org/394033002/diff/20001/google_apis/gcm/gcm.gyp File google_apis/gcm/gcm.gyp (left): https://codereview.chromium.org/394033002/diff/20001/google_apis/gcm/gcm.gyp#oldcode149 google_apis/gcm/gcm.gyp:149: 'mcs_probe', This removal was on purpose. It was depending ...

6 years, 5 months ago (2014-07-15 21:54:35 UTC) #1

brettw

6 years, 5 months ago (2014-07-16 20:26:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r283486 (presubmit successful).

Expand Messages | Collapse Messages