Retire gtestjs unit tests

Retire gtestjs unit tests

Now that the QUnit-based unit tests are running on the bots, we can retire gtestjs unit tests.

This CL
1. Modifies remoting_webapp_unittest to include all files that are formerly covered by all_js_load.gtestjs.
2. Removes all the gtestjs files under remoting.
3. Moves run_all_remoting_unittests.cc back into the remoting directory as we no longer depends on chrome_paths.h.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283941

[kelvinp, 2014-07-15 21:44:38]

PTAL

[garykac, 2014-07-15 23:23:42]

https://codereview.chromium.org/394023002/diff/1/chrome/js_unittest_rules.gypi
File chrome/js_unittest_rules.gypi (left):

https://codereview.chromium.org/394023002/diff/1/chrome/js_unittest_rules.gyp...
chrome/js_unittest_rules.gypi:30: # See
src/chrome/test/base/run_all_remoting_unittests.cc for an example.
Can js_unittest_rules.gypi and js_unittest_vars.gypi be removed entirely?

You may want to check in the remoting/... changes first and do the chrome/
cleanup in a separate cl.

Also, if this file sticks around, it should direct people to the new way to do
JS unittests rather than having all this misleading content.

https://codereview.chromium.org/394023002/diff/1/remoting/remoting_test.gypi
File remoting/remoting_test.gypi (right):

https://codereview.chromium.org/394023002/diff/1/remoting/remoting_test.gypi#...
remoting/remoting_test.gypi:43: 'base/run_all_unittests.cc',
alpha order

[kelvinp, 2014-07-16 00:17:55]

PTAL

https://codereview.chromium.org/394023002/diff/1/chrome/js_unittest_rules.gypi
File chrome/js_unittest_rules.gypi (left):

https://codereview.chromium.org/394023002/diff/1/chrome/js_unittest_rules.gyp...
chrome/js_unittest_rules.gypi:30: # See
src/chrome/test/base/run_all_remoting_unittests.cc for an example.
On 2014/07/15 23:23:42, garykac wrote:
> Can js_unittest_rules.gypi and js_unittest_vars.gypi be removed entirely?

Unfortunately, I can't remove js_unittest_rules.gypi and js_unittest_vars.gypi
as there are other tests in chrome still depend on gtestjs.

> 
> You may want to check in the remoting/... changes first and do the chrome/
> cleanup in a separate cl.
> 

I think I will leave this CL open for a few days.  If I didn't get approval from
owners of this file, then I will just check-in the chromoting part first.

> Also, if this file sticks around, it should direct people to the new way to do
> JS unittests rather than having all this misleading content.

Eventually, I will advertise the QUnit framework on dev.chromium.org.  I already
have a page going, http://dev.chromium.org/javascript-unittests.  So far, I only
got instructions about how to add test cases to an existing test suite.  Once I
got instructions to add new test suite, I will link it to the main page.

https://codereview.chromium.org/394023002/diff/1/remoting/remoting_test.gypi
File remoting/remoting_test.gypi (right):

https://codereview.chromium.org/394023002/diff/1/remoting/remoting_test.gypi#...
remoting/remoting_test.gypi:43: 'base/run_all_unittests.cc',
On 2014/07/15 23:23:42, garykac wrote:
> alpha order

Done.

[garykac, 2014-07-16 16:58:26]

lgtm

[sky, 2014-07-17 17:28:23]

LGTM

[kelvinp, 2014-07-17 17:31:09]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:31:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kelvinp@chromium.org/394023002/20001

[kelvinp, 2014-07-17 17:37:43]

The CQ bit was unchecked by kelvinp@chromium.org

[kelvinp, 2014-07-17 19:04:48]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2014-07-17 19:11:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kelvinp@chromium.org/394023002/40001

[commit-bot: I haz the power, 2014-07-18 00:06:43]

Change committed as 283941