Remove NSSCertDatabase from ClientCertStoreChromeOS unittest.

net/ssl/client_cert_store_chromeos.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SSL_CLIENT_CERT_STORE_CHROMEOS_H_
 #define NET_SSL_CLIENT_CERT_STORE_CHROMEOS_H_
 
 #include <string>
 
 #include "crypto/scoped_nss_types.h"
@@ skipping 22 matching lines @@
                                   CertificateList* selected_certs) OVERRIDE;
 
  private:
   friend class ClientCertStoreChromeOSTestDelegate;
 
   void DidGetPrivateSlot(const SSLCertRequestInfo* request,
                          CertificateList* selected_certs,
                          const base::Closure& callback,
                          crypto::ScopedPK11Slot private_slot);
 
-  // Allows tests to initialize the cert store with the given slots.

[pneubeck (no reviews), 2014/07/17 13:40:50]

I just noticed today these two functions that Matt initially added (likely
copy&pasted from the NSS implementation).
This indicates that he planned to indeed reuse the test templates in
client_cert_store_unittest-inl.h also for the ChromeOS implementation.

I updated the ChromeOS unittest to apply these test.
However, it wouldn't work to use these two functions only (i.e. don't import the
client certs into a DB but directly pass them to SelectClientCertsForTesting),
because the profile_filter_ does only accepts certs that _are_ stored in a
specific slot.

Thus, instead I removed these testing functions and test this class through its
public interface only (which is the preferred way anyways).
A minor glitch is that I have to import the private keys in advance, because the
test template doesn't provide them (could be changed of course).

In a follow up, I should update the NSS test to do the same.

-  // Must be called before SelectClientCertsForTesting.
-  void InitForTesting(crypto::ScopedPK11Slot public_slot,
-                      crypto::ScopedPK11Slot private_slot);
-
-  // A hook for testing. Filters |input_certs| using the logic being used to
-  // filter the system store when GetClientCerts() is called.
-  // Implemented by creating a list of certificates that otherwise would be
-  // extracted from the system store and filtering it using the common logic
-  // (less adequate than the approach used on Windows).
-  bool SelectClientCertsForTesting(const CertificateList& input_certs,
-                                   const SSLCertRequestInfo& cert_request_info,
-                                   CertificateList* selected_certs);
-
-
   std::string username_hash_;
   NSSProfileFilterChromeOS profile_filter_;
 
   DISALLOW_COPY_AND_ASSIGN(ClientCertStoreChromeOS);
 };
 
 }  // namespace net
 
 #endif  // NET_SSL_CLIENT_CERT_STORE_CHROMEOS_H_