Issue 394013002: Convert insets to pixels for app windows via the Scale method in the Insets class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 394013002: Convert insets to pixels for app windows via the Scale method in the Insets class. (Closed)

Created:
6 years, 5 months ago by ananta

Modified:
6 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Convert insets to pixels for app windows via the Scale method in the Insets class. This patch fixes a bug introduced with my earlier patch where in we were converting the insets to a rect incorrectly for converting it to pixels. This caused border artifacts for some app windows. BUG=393930 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283466

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
	M	chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc	View		1 chunk	+5 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/394013002/1

6 years, 5 months ago (2014-07-15 23:44:47 UTC) #4

Message was sent while issue was closed.

Change committed as 283466

Expand Messages | Collapse Messages