[Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py…

[Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py (Part-1)

Blink should make use of blink_resources.grd for the inline resources for displaying XML tree view.
This removes the dependency upon using xxd.py which embeds the resources as strings.

BUG=312586
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178214

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178411

[abarth-chromium, 2014-07-15 21:07:20]

LGTM

[vivekg, 2014-07-15 21:07:46]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-07-15 21:08:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/394003002/1

[commit-bot: I haz the power, 2014-07-15 22:16:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17084)

[commit-bot: I haz the power, 2014-07-15 23:03:34]

Change committed as 178214

[falken, 2014-07-16 02:10:30]

On 2014/07/15 23:03:34, I haz the power (commit-bot) wrote:
> Change committed as 178214

I think this probably caused a build failure on Android GN:
http://build.chromium.org/p/chromium.webkit/builders/Android%20GN/builds/3213
http://build.chromium.org/p/chromium.webkit/builders/Android%20GN/builds/3212

Log:
FAILED: python ../../build/android/gyp/process_resources.py --depfile
gen/ui/android/ui_java_res__process_resources.d --android-sdk
../../third_party/android_tools/sdk/platforms/android-19 --android-sdk-tools
../../third_party/android_tools/sdk/build-tools/19.0.0 --non-constant-id
--android-manifest ../../build/android/AndroidManifest.xml
--resource-dirs=\[\"../../ui/android/java/res\"\] --srcjar-out
gen/ui/android/ui_java_res.srcjar --resource-zip-out
gen/ui/android/ui_java_res.resources.zip
--dependencies-res-zips=@\(gen/ui/android/ui_java_res.build_config:resources:dependency_zips\)
--custom-package org.chromium.ui
Traceback (most recent call last):
  File "../../build/android/gyp/process_resources.py", line 260, in <module>
    main()
  File "../../build/android/gyp/process_resources.py", line 215, in main
    build_utils.CheckOutput(package_command, print_stderr=False)
  File
"/mnt/data/b/build/slave/Android_GN/build/src/build/android/gyp/util/build_utils.py",
line 154, in CheckOutput
    raise CalledProcessError(cwd, args, stdout + stderr)
util.build_utils.CalledProcessError: Command failed: ( cd
/mnt/data/b/build/slave/Android_GN/build/src/out/Release;
../../third_party/android_tools/sdk/build-tools/19.0.0/aapt package -m -M
../../build/android/AndroidManifest.xml --auto-add-overlay -I
../../third_party/android_tools/sdk/platforms/android-19/android.jar
--output-text-symbols /tmp/tmpX2vkJ3/gen -J /tmp/tmpX2vkJ3/gen -S
../../ui/android/java/res -S /tmp/tmpX2vkJ3/deps/ui_strings_grd.resources.zip
--non-constant-id --custom-package org.chromium.ui )
../../third_party/android_tools/sdk/build-tools/19.0.0/aapt: error while loading
shared libraries: libz.so.1: cannot open shared object file: No such file or
directory

ninja: build stopped: subcommand failed.

[falken, 2014-07-16 02:32:37]

A revert of this CL has been created in
https://codereview.chromium.org/397893002/ by falken@chromium.org.

The reason for reverting is: I think this probably caused a build failure on
Android GN:
http://build.chromium.org/p/chromium.webkit/builders/Android%20GN/builds/3213
http://build.chromium.org/p/chromium.webkit/builders/Android%20GN/builds/3212

Excerpt from log:
FAILED: python ../../build/android/gyp/process_resources.py --depfile
gen/ui/android/ui_java_res__process_resources.d --android-sdk
../../third_party/android_tools/sdk/platforms/android-19 --android-sdk-tools
../../third_party/android_tools/sdk/build-tools/19.0.0 --non-constant-id
--android-manifest ../../build/android/AndroidManifest.xml
--resource-dirs=\[\"../../ui/android/java/res\"\] --srcjar-out
gen/ui/android/ui_java_res.srcjar --resource-zip-out
gen/ui/android/ui_java_res.resources.zip
--dependencies-res-zips=@\(gen/ui/android/ui_java_res.build_config:resources:dependency_zips\)
--custom-package org.chromium.ui
Traceback (most recent call last):
  File "../../build/android/gyp/process_resources.py", line 260, in <module>
    main()
  File "../../build/android/gyp/process_resources.py", line 215, in main
    build_utils.CheckOutput(package_command, print_stderr=False)
  File
"/mnt/data/b/build/slave/Android_GN/build/src/build/android/gyp/util/build_utils.py",
line 154, in CheckOutput
    raise CalledProcessError(cwd, args, stdout + stderr)
util.build_utils.CalledProcessError: Command failed: ( cd
/mnt/data/b/build/slave/Android_GN/build/src/out/Release;
../../third_party/android_tools/sdk/build-tools/19.0.0/aapt package -m -M
../../build/android/AndroidManifest.xml --auto-add-overlay -I
../../third_party/android_tools/sdk/platforms/android-19/android.jar
--output-text-symbols /tmp/tmpX2vkJ3/gen -J /tmp/tmpX2vkJ3/gen -S
../../ui/android/java/res -S /tmp/tmpX2vkJ3/deps/ui_strings_grd.resources.zip
--non-constant-id --custom-package org.chromium.ui )
../../third_party/android_tools/sdk/build-tools/19.0.0/aapt: error while loading
shared libraries: libz.so.1: cannot open shared object file: No such file or
directory

ninja: build stopped: subcommand failed..

[vivekg, 2014-07-18 00:55:13]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-07-18 00:55:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/394003002/1

[vivekg, 2014-07-18 00:57:17]

Relanding this as the build break was not related to this CL as per
https://code.google.com/p/chromium/issues/detail?id=394239#c18

[commit-bot: I haz the power, 2014-07-18 01:21:50]

Change committed as 178411