Issue 3940002: Use scoped_refptr for refcounted param in DomStorageDispatcherHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3940002: Use scoped_refptr for refcounted param in DomStorageDispatcherHost. (Closed)

Created:
10 years, 2 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
jorlow

CC:
chromium-reviews, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use scoped_refptr for refcounted param in DomStorageDispatcherHost. BUG=28083 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63214

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

10 years, 2 months ago (2010-10-20 15:33:00 UTC) #3

Nope, it's unsafe to pass them as a raw pointer, since the RunnableMethod
task that gets created will store a Tuple with a raw pointer instead of a
scoped_refptr.  This means that before the task invokes the function pointer
later, its refcounted parameter may get deleted since the RunnableMethod
doesn't hold a refcount to it.

Once I fix all instances of this anti-pattern, I'm going to add a template
type trait to prevent anyone from doing this again.

On Wed, Oct 20, 2010 at 2:02 AM, <jorlow@chromium.org> wrote:

> LGTM
>
> Is this needed for clang or something?
>
>
> http://codereview.chromium.org/3940002/show
>

Expand Messages | Collapse Messages