Issue 393983009: test_runner: Rename WebTestThemeEngineMock to MockWebThemeEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 393983009: test_runner: Rename WebTestThemeEngineMock to MockWebThemeEngine. (Closed)

Created:
6 years, 5 months ago by tfarina

Modified:
6 years, 5 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, jochen (gone - plz use gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

test_runner: Rename WebTestThemeEngineMock to MockWebThemeEngine. Plus some minor style fixes, mainly clang-format the header. Source file was not fully converted to Chromium C++ style, because it is too big to be done manually and to be fun :/ BUG=331299 TEST=content_unittests, content_shell. No functional changes TBR=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284345

Patch Set 1 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -744 lines)			Patch
M	content/content_shell.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/renderer/test_runner/TestInterfaces.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/renderer/test_runner/TestInterfaces.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	content/shell/renderer/test_runner/WebTestThemeEngineMock.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	content/shell/renderer/test_runner/WebTestThemeEngineMock.cpp	View	1 chunk	+0 lines, -648 lines	0 comments	Download
A +	content/shell/renderer/test_runner/mock_web_theme_engine.h	View	1 chunk	+14 lines, -16 lines	0 comments	Download
A +	content/shell/renderer/test_runner/mock_web_theme_engine.cc	View	12 chunks	+42 lines, -46 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/393983009/20001

6 years, 5 months ago (2014-07-19 19:12:33 UTC) #3

Message was sent while issue was closed.

seems fine. lgtm.

Expand Messages | Collapse Messages