Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 393983004: Move mojo/examples/html_viewer to mojo/services/html_viewer. (Closed)

Created:
6 years, 5 months ago by Aaron Boodman
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move mojo/examples/html_viewer to mojo/services/html_viewer. BUG=389369 R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283426

Patch Set 1 #

Patch Set 2 : sort #

Total comments: 1

Patch Set 3 : nuke 'examples' namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -1975 lines) Patch
D mojo/examples/html_viewer/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D mojo/examples/html_viewer/blink_input_events_type_converters.h View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/examples/html_viewer/blink_input_events_type_converters.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D mojo/examples/html_viewer/blink_platform_impl.h View 1 chunk +0 lines, -81 lines 0 comments Download
D mojo/examples/html_viewer/blink_platform_impl.cc View 1 chunk +0 lines, -217 lines 0 comments Download
D mojo/examples/html_viewer/html_document_view.h View 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/examples/html_viewer/html_document_view.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D mojo/examples/html_viewer/html_viewer.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D mojo/examples/html_viewer/webmimeregistry_impl.h View 1 chunk +0 lines, -50 lines 0 comments Download
D mojo/examples/html_viewer/webmimeregistry_impl.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D mojo/examples/html_viewer/webstoragenamespace_impl.h View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/examples/html_viewer/webstoragenamespace_impl.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/examples/html_viewer/webthemeengine_impl.h View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/examples/html_viewer/webthemeengine_impl.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D mojo/examples/html_viewer/webthread_impl.h View 1 chunk +0 lines, -75 lines 0 comments Download
D mojo/examples/html_viewer/webthread_impl.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D mojo/examples/html_viewer/weburlloader_impl.h View 1 chunk +0 lines, -65 lines 0 comments Download
D mojo/examples/html_viewer/weburlloader_impl.cc View 1 chunk +0 lines, -191 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 chunk +0 lines, -44 lines 0 comments Download
M mojo/mojo_services.gypi View 1 1 chunk +44 lines, -0 lines 0 comments Download
A + mojo/services/html_viewer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/services/html_viewer/blink_input_events_type_converters.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/html_viewer/blink_input_events_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/html_viewer/blink_platform_impl.h View 1 2 3 chunks +5 lines, -8 lines 0 comments Download
A + mojo/services/html_viewer/blink_platform_impl.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
A + mojo/services/html_viewer/html_document_view.h View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
A + mojo/services/html_viewer/html_document_view.cc View 1 2 4 chunks +4 lines, -7 lines 0 comments Download
A + mojo/services/html_viewer/html_viewer.cc View 1 2 3 chunks +3 lines, -8 lines 0 comments Download
A + mojo/services/html_viewer/webmimeregistry_impl.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
A + mojo/services/html_viewer/webmimeregistry_impl.cc View 1 2 3 chunks +1 line, -3 lines 0 comments Download
A + mojo/services/html_viewer/webstoragenamespace_impl.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
A + mojo/services/html_viewer/webstoragenamespace_impl.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
A + mojo/services/html_viewer/webthemeengine_impl.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
A + mojo/services/html_viewer/webthemeengine_impl.cc View 1 2 3 chunks +1 line, -3 lines 0 comments Download
A + mojo/services/html_viewer/webthread_impl.h View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
A + mojo/services/html_viewer/webthread_impl.cc View 1 2 3 chunks +1 line, -3 lines 0 comments Download
A + mojo/services/html_viewer/weburlloader_impl.h View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
A + mojo/services/html_viewer/weburlloader_impl.cc View 1 2 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Aaron Boodman
6 years, 5 months ago (2014-07-15 22:12:46 UTC) #1
darin (slow to review)
mojo::examples:: namespace should just change to mojo:: https://codereview.chromium.org/393983004/diff/10039/mojo/services/html_viewer/html_document_view.h File mojo/services/html_viewer/html_document_view.h (right): https://codereview.chromium.org/393983004/diff/10039/mojo/services/html_viewer/html_document_view.h#newcode26 mojo/services/html_viewer/html_document_view.h:26: namespace examples ...
6 years, 5 months ago (2014-07-15 22:17:31 UTC) #2
Aaron Boodman
On 2014/07/15 22:17:31, darin wrote: > mojo::examples:: namespace should just change to mojo:: > > ...
6 years, 5 months ago (2014-07-15 22:59:21 UTC) #3
darin (slow to review)
LGTM
6 years, 5 months ago (2014-07-15 23:18:56 UTC) #4
Aaron Boodman
The CQ bit was checked by aa@chromium.org
6 years, 5 months ago (2014-07-15 23:28:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/393983004/30001
6 years, 5 months ago (2014-07-15 23:29:59 UTC) #6
Aaron Boodman
6 years, 5 months ago (2014-07-16 18:02:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r283426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698