Allow QUIC clients to accept STK/SCFG updates on an existing connection.

Allow QUIC clients to accept STK/SCFG updates on an existing connection.

Merge internal change: 70794017

R=rch@chromium.org, wtc@chromium.org

TODO: Will submit a separate CL to persist the new STK/SCFG.

[Ryan Hamilton, 2014-07-16 15:55:43]

lgtm

[wtc, 2014-07-16 17:03:06]

Patch set 1 LGTM.

https://codereview.chromium.org/393953011/diff/1/net/quic/quic_crypto_client_...
File net/quic/quic_crypto_client_stream.h (right):

https://codereview.chromium.org/393953011/diff/1/net/quic/quic_crypto_client_...
net/quic/quic_crypto_client_stream.h:109: void
HandleServerConfigUpdateMessage(const CryptoHandshakeMessage* in);

I seem to remember I also suggested changing this input parameter to a const
ref. If Robbie didn't make this change, you can do it.

The DoHandshakeLoop function below must declare its input as a pointer because
we sometimes need to pass NULL to DoHandshakeLoop.

[ramant (doing other things), 2014-07-16 19:43:22]

Fixed the comments in CL: https://codereview.chromium.org/394053003/ and will
merge that back into the internal source tree.

https://codereview.chromium.org/393953011/diff/1/net/quic/quic_crypto_client_...
File net/quic/quic_crypto_client_stream.h (right):

https://codereview.chromium.org/393953011/diff/1/net/quic/quic_crypto_client_...
net/quic/quic_crypto_client_stream.h:109: void
HandleServerConfigUpdateMessage(const CryptoHandshakeMessage* in);
On 2014/07/16 17:03:06, wtc wrote:
> 
> I seem to remember I also suggested changing this input parameter to a const
> ref. If Robbie didn't make this change, you can do it.
> 
> The DoHandshakeLoop function below must declare its input as a pointer because
> we sometimes need to pass NULL to DoHandshakeLoop.

Done.

[ramant (doing other things), 2014-07-16 19:47:57]

Fixed the comments in CL: https://codereview.chromium.org/394053003/ and will
merge that back into the internal source tree.