src/gpu/GrTextStrike.cpp - Issue 393953004: SkAutoRef seems lonely. Might as well delete it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrTextStrike.cpp

Issue 393953004: SkAutoRef seems lonely. Might as well delete it. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: simpler Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/GrTextStrike.cpp

diff --git a/src/gpu/GrTextStrike.cpp b/src/gpu/GrTextStrike.cpp

index 4079893b3a0b9cc74475675cc17bc774903d34be..46d7a537ce53890c558d3f4899d40c24f316dda5 100644

--- a/src/gpu/GrTextStrike.cpp

+++ b/src/gpu/GrTextStrike.cpp

@@ -293,7 +293,7 @@ bool GrTextStrike::addGlyphToAtlas(GrGlyph* glyph, GrFontScaler* scaler) {

SkASSERT(fCache.contains(glyph));

SkASSERT(NULL == glyph->fPlot);

- SkAutoRef ar(scaler);

+ SkAutoUnref ar(SkSafeRef(scaler));

int bytesPerPixel = GrMaskFormatBytesPerPixel(fMaskFormat);

« no previous file with comments | « include/core/SkRefCnt.h ('k') | no next file » | no next file with comments »