Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 393953004: SkAutoRef seems lonely. Might as well delete it. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkAutoRef seems lonely. Might as well delete it. (On the other hand, SkAutoUnref is well-used.) NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a179a1ede9e8ff17e23a61a55d822e862d09b8e8

Patch Set 1 #

Patch Set 2 : simpler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M include/core/SkRefCnt.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 5 months ago (2014-07-15 19:42:06 UTC) #1
bungeman-skia
lgtm
6 years, 5 months ago (2014-07-15 20:00:48 UTC) #2
mtklein
+reed for removing code from include/
6 years, 5 months ago (2014-07-15 20:03:04 UTC) #3
reed1
lgtm
6 years, 5 months ago (2014-07-15 20:07:27 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-15 20:09:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/393953004/20001
6 years, 5 months ago (2014-07-15 20:09:57 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 20:29:38 UTC) #7
Message was sent while issue was closed.
Change committed as a179a1ede9e8ff17e23a61a55d822e862d09b8e8

Powered by Google App Engine
This is Rietveld 408576698