Issue 393953004: SkAutoRef seems lonely. Might as well delete it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 393953004: SkAutoRef seems lonely. Might as well delete it. (Closed)

Created:
6 years, 5 months ago by mtklein_C

Modified:
6 years, 5 months ago

Reviewers:
bungeman-skia, mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

SkAutoRef seems lonely. Might as well delete it. (On the other hand, SkAutoUnref is well-used.) NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a179a1ede9e8ff17e23a61a55d822e862d09b8e8

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -10 lines)			Patch
	M	include/core/SkRefCnt.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
	M	src/gpu/GrTextStrike.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/393953004/20001

6 years, 5 months ago (2014-07-15 20:09:57 UTC) #6

commit-bot: I haz the power

6 years, 5 months ago (2014-07-15 20:29:38 UTC) #7

Message was sent while issue was closed.

Change committed as a179a1ede9e8ff17e23a61a55d822e862d09b8e8