Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 393943003: Settings page sliding transition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: force style recalc Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index c7bcb147c8cd40ab170006dd21461063323f6249..edf02ec4b84b84097f183655575a14ba3b7542fc 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -745,6 +745,9 @@ cr.define('options', function() {
section.style.height = (showing ? 0 : container.offsetHeight) + 'px';
section.classList.add('sliding');
+ // Force a style recalc before starting the animation.
Dan Beam 2014/09/10 22:56:34 can you please add a /** @suppress {uselessCod
michaelpg 2014/09/10 23:19:52 Done.
+ section.offsetHeight;
+
if (this.sectionHeightChangeTimeout_ !== null)
clearTimeout(this.sectionHeightChangeTimeout_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698