Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Issue 393933003: mac: Fix tab dragging visual bug in Yosemite. (reland) (Closed)

Created:
6 years, 5 months ago by erikchen
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Fix tab dragging visual bug in Yosemite. (reland) -----------------Reland Description------------------ Core animation was turned on in M35. The fullscreen window was not layer backed, but should have been. This original CL exposed this bug. -----------------Original Description------------------ In OSX 10.10+, all views must be added to the NSWindow's contentView. Some views (like the tab strip and the profile icon) are placed on top of the title bar and require special treatment. All other views are added as subviews of 'chromeContentView' in TabWindowController. This allows tab dragging and fullscreen logic to easily move the views that don't need special treatment. This CL also removes the instances where a VersionIndependentWindow's contentView gets replaced by setContentView:. Instead, the 'chromeContentView' gets passed around as a subview. This allows VersionIndependentWindow to remove another of its internal hacks. Original CL link: https://codereview.chromium.org/379293003/ BUG=392239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283456

Patch Set 1 : Copy of patch set 7 from https://codereview.chromium.org/379293003/ #

Patch Set 2 : Add layer backing to fullscreen window. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -26 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_window.mm View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 5 chunks +24 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/version_independent_window.mm View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
erikchen
andresantoso: Please review.
6 years, 5 months ago (2014-07-15 21:06:14 UTC) #1
Andre
lgtm
6 years, 5 months ago (2014-07-15 21:26:52 UTC) #2
erikchen
shess: Please review.
6 years, 5 months ago (2014-07-15 21:28:08 UTC) #3
Scott Hess - ex-Googler
lgtm
6 years, 5 months ago (2014-07-15 21:34:55 UTC) #4
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 5 months ago (2014-07-15 21:47:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/393933003/20001
6 years, 5 months ago (2014-07-15 21:51:04 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 05:22:41 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 05:43:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171106)
6 years, 5 months ago (2014-07-16 05:43:28 UTC) #9
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 5 months ago (2014-07-16 15:32:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/393933003/20001
6 years, 5 months ago (2014-07-16 15:34:15 UTC) #11
commit-bot: I haz the power
Change committed as 283456
6 years, 5 months ago (2014-07-16 18:54:03 UTC) #12
agable
6 years, 5 months ago (2014-07-16 22:08:55 UTC) #13
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/398903003/ by agable@chromium.org.

The reason for reverting is: Broke TestActivate and TestFullscreen on Mac 10.6
Tests
(http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%282%29/b...).

Powered by Google App Engine
This is Rietveld 408576698