Make security team owners of message file .cc implementations as well as headers.

Make security team owners of message file .cc implementations as well as headers.

TBR=jam@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283221

[Tom Sepez, 2014-07-15 18:13:53]

TBR because this is leaving some other CLs in the lurch.

[Tom Sepez, 2014-07-15 18:14:29]

The CQ bit was checked by tsepez@chromium.org

[jam, 2014-07-15 18:17:09]

https://codereview.chromium.org/393933002/diff/1/content/common/OWNERS
File content/common/OWNERS (right):

https://codereview.chromium.org/393933002/diff/1/content/common/OWNERS#newcode34
content/common/OWNERS:34: per-file *_messages.cc=set noparent
can you combine this with the above into _message*.*?

[Tom Sepez, 2014-07-15 18:18:02]

The CQ bit was unchecked by tsepez@chromium.org

[danakj, 2014-07-15 18:18:27]

https://codereview.chromium.org/393933002/diff/1/content/common/OWNERS
File content/common/OWNERS (right):

https://codereview.chromium.org/393933002/diff/1/content/common/OWNERS#newcode34
content/common/OWNERS:34: per-file *_messages.cc=set noparent
On 2014/07/15 18:17:09, jam wrote:
> can you combine this with the above into _message*.*?

That would include things like cc_messages_unittest.cc, and with the noparent,
that'd be incorrect I think?

[Tom Sepez, 2014-07-15 18:20:02]

> That would include things like cc_messages_unittest.cc, and with the noparent,
> that'd be incorrect I think?
Ah.  Indeed.  Security team doesn't worry about _unittest.cc, and would not want
to get in the way of those poking at it.

[Tom Sepez, 2014-07-15 18:20:06]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2014-07-15 18:21:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tsepez@chromium.org/393933002/1

[jam, 2014-07-15 18:21:56]

On 2014/07/15 18:20:02, Tom Sepez wrote:
> > That would include things like cc_messages_unittest.cc, and with the
noparent,
> > that'd be incorrect I think?
> Ah.  Indeed.  Security team doesn't worry about _unittest.cc, and would not
want
> to get in the way of those poking at it.

good point, ok nvm. lgtm

how awesome would it be if our OWNERS system had a way of referencing a group of
emails in some file so that we don't duplicate the list of security folks all
over :)

[commit-bot: I haz the power, 2014-07-15 18:24:06]

Change committed as 283221