src/effects/SkArithmeticMode.cpp - Issue 39393002: Always create an instance when testing GrEffects for SkXfermode and SkArithmeticMode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkArithmeticMode.cpp

Issue 39393002: Always create an instance when testing GrEffects for SkXfermode and SkArithmeticMode (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkArithmeticMode.cpp

diff --git a/src/effects/SkArithmeticMode.cpp b/src/effects/SkArithmeticMode.cpp

index 3c445ab4851cfea4285c54a99857ae34b65330c9..2cec1536fe5925e077bf4e8dfc35a4c6c2b031a7 100644

--- a/src/effects/SkArithmeticMode.cpp

+++ b/src/effects/SkArithmeticMode.cpp

@@ -402,7 +402,7 @@ GrEffectRef* GrArithmeticEffect::TestCreate(SkRandom* rand,

float k3 = rand->nextF();

float k4 = rand->nextF();

- static AutoEffectUnref gEffect(SkNEW_ARGS(GrArithmeticEffect, (k1, k2, k3, k4, NULL)));

+ AutoEffectUnref gEffect(SkNEW_ARGS(GrArithmeticEffect, (k1, k2, k3, k4, NULL)));

return CreateEffectRef(gEffect);

}

« no previous file with comments | « src/core/SkXfermode.cpp ('k') | no next file » | no next file with comments »