Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 39393002: Always create an instance when testing GrEffects for SkXfermode and SkArithmeticMode (Closed)

Created:
7 years, 1 month ago by Kimmo Kinnunen
Modified:
7 years, 1 month ago
Reviewers:
bsalomon, senorblanco
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Always create an instance when testing GrEffects for SkXfermode and SkArithmeticMode Previously the TestCreate methods of the effects would create a static instance and return that for all invocations. This is probably a copy-paste error going back to initial TestCreate method in r8449. At that time, the effect was always the same and thus static usage made sense. Committed: http://code.google.com/p/skia/source/detail?r=11939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/core/SkXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Kimmo Kinnunen
I think you guys have worked on code related to this
7 years, 1 month ago (2013-10-24 05:44:30 UTC) #1
bsalomon
lgtm
7 years, 1 month ago (2013-10-24 13:12:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/39393002/1
7 years, 1 month ago (2013-10-24 13:12:26 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-24 13:33:34 UTC) #4
Message was sent while issue was closed.
Change committed as 11939

Powered by Google App Engine
This is Rietveld 408576698