Issue 39393002: Always create an instance when testing GrEffects for SkXfermode and SkArithmeticMode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39393002: Always create an instance when testing GrEffects for SkXfermode and SkArithmeticMode (Closed)

Created:
7 years, 1 month ago by Kimmo Kinnunen

Modified:
7 years, 1 month ago

Reviewers:
bsalomon, senorblanco

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Always create an instance when testing GrEffects for SkXfermode and SkArithmeticMode Previously the TestCreate methods of the effects would create a static instance and return that for all invocations. This is probably a copy-paste error going back to initial TestCreate method in r8449. At that time, the effect was always the same and thus static usage made sense. Committed: http://code.google.com/p/skia/source/detail?r=11939