Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 393913002: Remove SkRefPtr. (Closed)

Created:
6 years, 5 months ago by bungeman-skia
Modified:
6 years, 5 months ago
Reviewers:
mtklein, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Move semantics for Android FCI implementation. #

Patch Set 3 : Fix parameter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -49 lines) Patch
M include/core/SkRefCnt.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
M src/ports/SkFontConfigInterface_android.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M tests/UtilsTest.cpp View 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bungeman-skia
Try again to rid ourselves of SkRefPtr. I've done a search of Chromium, Blink, and ...
6 years, 5 months ago (2014-07-15 17:34:50 UTC) #1
reed1
lgtm
6 years, 5 months ago (2014-07-15 17:45:18 UTC) #2
mtklein
lgtm
6 years, 5 months ago (2014-07-15 18:01:49 UTC) #3
bsalomon
lgtm
6 years, 5 months ago (2014-07-17 15:27:51 UTC) #4
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 5 months ago (2014-07-17 19:05:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/393913002/40001
6 years, 5 months ago (2014-07-17 19:06:13 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 19:18:00 UTC) #7
Message was sent while issue was closed.
Change committed as 733418f91e4d90f4ec250d9a97120618a5a89b49

Powered by Google App Engine
This is Rietveld 408576698