Fix RLZ test support dependency.

Fix RLZ test support dependency.

BUG=393815
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283753

[gab, 2014-07-16 17:30:03]

LGTM, the code to support the legacy device ID is about to be removed anyways
(and thus this test as well).

Thanks,
Gab

[Nico, 2014-07-16 17:33:25]

https://codereview.chromium.org/393903002/diff/20001/chrome/chrome_tests_unit...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/393903002/diff/20001/chrome/chrome_tests_unit...
chrome/chrome_tests_unit.gypi:2490: '../rlz/rlz.gyp:test_support_rlz',
Isn't it better to only add the dependency if it's needed? (For sources, the
list-everything-and-then-remove thing kind of makes sense, since the sources
then show up in IDEs with gyp's msvs/xcode generators, but I don't think they do
something like that for dependencies.)

[grt (UTC plus 2), 2014-07-16 18:08:01]

PTAL

https://codereview.chromium.org/393903002/diff/20001/chrome/chrome_tests_unit...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/393903002/diff/20001/chrome/chrome_tests_unit...
chrome/chrome_tests_unit.gypi:2490: '../rlz/rlz.gyp:test_support_rlz',
On 2014/07/16 17:33:25, Nico (away) wrote:
> Isn't it better to only add the dependency if it's needed? (For sources, the
> list-everything-and-then-remove thing kind of makes sense, since the sources
> then show up in IDEs with gyp's msvs/xcode generators, but I don't think they
do
> something like that for dependencies.)

I have no idea. I see other places in this file that remove a dependency in a
condition. Since it gave you pause, I've switched it as requested.

[Nico, 2014-07-16 18:09:05]

lgtm

Thanks, that's less confusing to me :-)

[grt (UTC plus 2), 2014-07-16 18:10:34]

On 2014/07/16 18:09:05, Nico (away) wrote:
> lgtm
> 
> Thanks, that's less confusing to me :-)

Groovy. Probably less confusing to others as well. Thanks.

[grt (UTC plus 2), 2014-07-16 18:13:19]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2014-07-16 18:16:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/grt@chromium.org/393903002/40001

[commit-bot: I haz the power, 2014-07-16 21:36:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-17 11:22:37]

Change committed as 283753