Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 393873003: Use WebNode::getElementsByHTMLTagName instead of getElementsByTagName. (Closed)

Created:
6 years, 5 months ago by tkent
Modified:
6 years, 5 months ago
Reviewers:
Ilya Sherman, boliu
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, android-webview-reviews_chromium.org, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use WebNode::getElementsByHTMLTagName instead of getElementsByTagName. We're going to remove WebNode::getElementsByTagName. BUG=394234 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M android_webview/renderer/aw_render_view_ext.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tkent
boliu@, isherman@, would you review this please?
6 years, 5 months ago (2014-07-17 00:10:19 UTC) #1
boliu
lgtm
6 years, 5 months ago (2014-07-17 00:38:33 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 5 months ago (2014-07-17 18:45:10 UTC) #3
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-17 18:45:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/393873003/1
6 years, 5 months ago (2014-07-17 18:49:07 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 22:25:32 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 23:46:45 UTC) #7
Message was sent while issue was closed.
Change committed as 283928

Powered by Google App Engine
This is Rietveld 408576698