Switch Blink to the new Web Notifications permission path.

Source/modules/notifications/Notification.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 21 matching lines @@
 #include "modules/notifications/Notification.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "core/dom/Document.h"
 #include "core/events/Event.h"
 #include "core/frame/UseCounter.h"
 #include "core/page/WindowFocusAllowedIndicator.h"
 #include "modules/notifications/NotificationClient.h"
 #include "modules/notifications/NotificationController.h"
+#include "modules/notifications/NotificationPermissionClient.h"
 
 namespace blink {
 
 Notification* Notification::create(ExecutionContext* context, const String& title, const Dictionary& options)
 {
     NotificationClient& client = NotificationController::clientFrom(context);
     Notification* notification = adoptRefCountedGarbageCollectedWillBeNoop(new Notification(title, context, &client));
 
     String argument;
     if (DictionaryHelper::get(options, "body", argument))
@@ skipping 109 matching lines @@
 }
 
 const String& Notification::permission(ExecutionContext* context)
 {
     UseCounter::count(context, UseCounter::NotificationPermission);
     return permissionString(NotificationController::clientFrom(context).checkPermission(context));
 }
 
 void Notification::requestPermission(ExecutionContext* context, PassOwnPtr<NotificationPermissionCallback> callback)
 {
-    ASSERT(toDocument(context)->page());
-    NotificationController::clientFrom(context).requestPermission(context, callback);
+    NotificationPermissionClient* permissionClient = NotificationPermissionClient::from(context);
+    if (permissionClient) {

[abarth-chromium, 2014/07/29 16:52:29]

You can merge these two lines.

[Peter Beverloo, 2014/07/30 11:22:55]

Done.

+        permissionClient->requestPermission(context, callback);
+        return;
+    }
+
+    // FIXME: What is the intended behavior for Notification.requestPermission when called
+    // from a Worker context? Should it be a no-op, or should |callback| be invoked with
+    // the current permission level?

[Peter Beverloo, 2014/07/28 17:03:16]

note: I've sent an e-mail to the WHATWG list to clarify what the intended
behavior for workers should be.

 }
 
 bool Notification::dispatchEvent(PassRefPtrWillBeRawPtr<Event> event)
 {
     ASSERT(m_state != NotificationStateClosed);
 
     return EventTarget::dispatchEvent(event);
 }
 
 const AtomicString& Notification::interfaceName() const
@@ skipping 12 matching lines @@
 
     m_asyncRunner.stop();
 }
 
 bool Notification::hasPendingActivity() const
 {
     return m_state == NotificationStateShowing || m_asyncRunner.isActive();
 }
 
 } // namespace blink