Issue 393863002: Switch Blink to the new Web Notifications permission path.

Issue 393863002: Switch Blink to the new Web Notifications permission path. (Closed)

Created:
6 years, 5 months ago by Peter Beverloo

Modified:
6 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit), abarth-chromium

CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Switch Blink to the new Web Notifications permission path. BUG=392187, 398045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179310

Patch Set 4 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -90 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download
M	LayoutTests/fast/notifications/notifications-constructor-request-permission.html	View		1 chunk	+38 lines, -27 lines	0 comments	Download
M	LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/notifications/notifications-constructor-without-permission.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/notifications/notifications-permission-values.html	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	Source/modules/notifications/Notification.cpp	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/modules/notifications/NotificationClient.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/web/NotificationPermissionClientImpl.cpp	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	Source/web/NotificationPresenterImpl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/NotificationPresenterImpl.cpp	View	1	2 chunks	+0 lines, -36 lines	0 comments	Download
M	public/web/WebNotificationPresenter.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Peter Beverloo

This should land after CL 395883002. https://codereview.chromium.org/393863002/diff/20001/Source/modules/notifications/Notification.cpp File Source/modules/notifications/Notification.cpp (right): https://codereview.chromium.org/393863002/diff/20001/Source/modules/notifications/Notification.cpp#newcode180 Source/modules/notifications/Notification.cpp:180: // the current ...

6 years, 4 months ago (2014-07-28 17:03:16 UTC) #1

abarth-chromium

LGTM https://codereview.chromium.org/393863002/diff/20001/Source/modules/notifications/Notification.cpp File Source/modules/notifications/Notification.cpp (right): https://codereview.chromium.org/393863002/diff/20001/Source/modules/notifications/Notification.cpp#newcode173 Source/modules/notifications/Notification.cpp:173: if (permissionClient) { You can merge these two ...

6 years, 4 months ago (2014-07-29 16:52:29 UTC) #2

Peter Beverloo

https://codereview.chromium.org/393863002/diff/20001/Source/modules/notifications/Notification.cpp File Source/modules/notifications/Notification.cpp (right): https://codereview.chromium.org/393863002/diff/20001/Source/modules/notifications/Notification.cpp#newcode173 Source/modules/notifications/Notification.cpp:173: if (permissionClient) { On 2014/07/29 16:52:29, abarth wrote: > ...

6 years, 4 months ago (2014-07-30 11:22:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/393863002/60001

6 years, 4 months ago (2014-07-31 13:06:40 UTC) #5

Message was sent while issue was closed.

Change committed as 179310

Expand Messages | Collapse Messages