content_renderer: Depend on libyuv even if WebRTC is not enabled.

content_renderer: Depend on libyuv even if WebRTC is not enabled.

video_decoder_shim.cc uses libyuv, and the build fails if we're not
building in component=shared_library mode and enable_webrtc=0:

In file included from ../../third_party/libyuv/include/libyuv.h:15:0,
                 from ../../content/renderer/pepper/video_decoder_shim.cc:25:
../../third_party/libyuv/include/libyuv/compare.h:14:32: fatal error: libyuv/basic_types.h: No such file or directory
 #include "libyuv/basic_types.h"
                                ^

R=dmichael@chromium.org, bbudge@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283541

[Raphael Kubo da Costa (rakuco), 2014-07-15 12:46:26]

https://codereview.chromium.org/393813002/diff/1/content/content_renderer.gypi
File content/content_renderer.gypi (right):

https://codereview.chromium.org/393813002/diff/1/content/content_renderer.gyp...
content/content_renderer.gypi:856: '../third_party/libyuv/libyuv.gyp:libyuv',
I'm not sure depending on libyuv both here and if enable_webrtc=1 is OK or
whether I should only depend on it once somewhere else.

[bbudge, 2014-07-16 01:20:12]

https://codereview.chromium.org/393813002/diff/1/content/content_renderer.gypi
File content/content_renderer.gypi (right):

https://codereview.chromium.org/393813002/diff/1/content/content_renderer.gyp...
content/content_renderer.gypi:856: '../third_party/libyuv/libyuv.gyp:libyuv',
On 2014/07/15 12:46:26, Raphael Kubo da Costa (rakuco) wrote:
> I'm not sure depending on libyuv both here and if enable_webrtc=1 is OK or
> whether I should only depend on it once somewhere else.

I'm no gyp expert but it seems OK to me. But you'll need OWNERS approval (I'm
not an OWNER here), and they might be able to better answer your question.

[Raphael Kubo da Costa (rakuco), 2014-07-16 07:26:03]

+jam, brettw, jochen for content/

[jochen (gone - plz use gerrit), 2014-07-16 08:57:52]

lgtm

[Raphael Kubo da Costa (rakuco), 2014-07-16 10:03:06]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2014-07-16 10:04:17]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/393813...

[commit-bot: I haz the power, 2014-07-16 22:13:53]

Change committed as 283541