Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 393803002: [Wallpaper Picker] s/commondatastorage.googleapis.com/storage.googleapis.com/g (Closed)

Created:
6 years, 5 months ago by François Beaufort
Modified:
6 years, 5 months ago
Reviewers:
bshe
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Wallpaper Picker] s/commondatastorage.googleapis.com/storage.googleapis.com/g BUG=329247 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283530

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
François Beaufort
Hello Biao, Do you mind having a look at this simple CL?
6 years, 5 months ago (2014-07-15 12:05:36 UTC) #1
bshe
https://codereview.chromium.org/393803002/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js File chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js (right): https://codereview.chromium.org/393803002/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js#newcode53 chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js:53: 'chromeos-wallpaper-public/cros-wallpaper-uri', Please keep WallpaperNameSpaceURI unchanged. We need to change ...
6 years, 5 months ago (2014-07-16 08:51:31 UTC) #2
François Beaufort
On 2014/07/16 08:51:31, bshe wrote: > https://codereview.chromium.org/393803002/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js > File chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js > (right): > > https://codereview.chromium.org/393803002/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js#newcode53 ...
6 years, 5 months ago (2014-07-16 08:55:44 UTC) #3
bshe
On 2014/07/16 08:55:44, François Beaufort wrote: > On 2014/07/16 08:51:31, bshe wrote: > > > ...
6 years, 5 months ago (2014-07-16 08:58:56 UTC) #4
François Beaufort
The CQ bit was checked by beaufort.francois@gmail.com
6 years, 5 months ago (2014-07-16 08:59:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaufort.francois@gmail.com/393803002/20001
6 years, 5 months ago (2014-07-16 09:01:43 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 21:53:12 UTC) #7
Message was sent while issue was closed. 
Change committed as 283530

Powered by Google App Engine
This is Rietveld 408576698