Separate GeoNotifier class from Geolocation

Separate GeoNotifier class from Geolocation

There are some classes in the Geolocation.h/cpp files.
It makes hard to read geolocation implementation, therefore
separate GeoNotifier from Geolocation is better.

BUG=387656
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178237

[kihong, 2014-07-15 10:37:17]

PTAL

[Michael van Ouwerkerk, 2014-07-15 13:47:09]

lgtm as it's a pretty clean cut & paste but I'm a little concerned about the
circular dependency

Adding Peter as second reviewer.

https://codereview.chromium.org/393793003/diff/1/Source/modules/geolocation/G...
File Source/modules/geolocation/GeoNotifier.cpp (right):

https://codereview.chromium.org/393793003/diff/1/Source/modules/geolocation/G...
Source/modules/geolocation/GeoNotifier.cpp:17: // FIXME : m_geolocation sould be
removed, it makes circular dependancy.
How do you plan to fix this?

[Michael van Ouwerkerk, 2014-07-15 13:47:34]

Also, please run 'git cl try'.

[kihong, 2014-07-15 14:43:53]

On 2014/07/15 13:47:09, Michael van Ouwerkerk wrote:
> lgtm as it's a pretty clean cut & paste but I'm a little concerned about the
> circular dependency
> 
> Adding Peter as second reviewer.
> 
>
https://codereview.chromium.org/393793003/diff/1/Source/modules/geolocation/G...
> File Source/modules/geolocation/GeoNotifier.cpp (right):
> 
>
https://codereview.chromium.org/393793003/diff/1/Source/modules/geolocation/G...
> Source/modules/geolocation/GeoNotifier.cpp:17: // FIXME : m_geolocation sould
be
> removed, it makes circular dependancy.
> How do you plan to fix this?

Current implementation does have a problem technically, because
GeoNotification.h doesn't inlcude Geolocation.h.
But as we know, it could be a problem potentially.
So, I am considering about removing m_geolocation and m_timer from GeoNotifier.
If Geolocation has a timer for dispatch event using GeoNotifier, GeoNotifier
doesn't need to have a m_geolocation at all.

[kihong, 2014-07-15 15:05:16]

https://codereview.chromium.org/393793003/diff/1/Source/modules/geolocation/G...
File Source/modules/geolocation/GeoNotifier.cpp (right):

https://codereview.chromium.org/393793003/diff/1/Source/modules/geolocation/G...
Source/modules/geolocation/GeoNotifier.cpp:17: // FIXME : m_geolocation sould be
removed, it makes circular dependancy.
"sould -> should" will be changed before landing.

[kihong, 2014-07-15 15:06:02]

On 2014/07/15 13:47:34, Michael van Ouwerkerk wrote:
> Also, please run 'git cl try'.

Sure I will do that.
Thank you :)

[kihong, 2014-07-16 02:40:22]

The CQ bit was checked by kihong.kwon@samsung.com

[commit-bot: I haz the power, 2014-07-16 02:41:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/393793003/20001

[commit-bot: I haz the power, 2014-07-16 03:41:41]

Change committed as 178237