Source/modules/serviceworkers/ServiceWorkerContainer.h - Issue 393773004: Oilpan: improve ScriptPromiseProperty's argument types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.h

Issue 393773004: Oilpan: improve ScriptPromiseProperty's argument types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Don't add a ref-cycle Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/serviceworkers/ServiceWorkerContainer.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.h b/Source/modules/serviceworkers/ServiceWorkerContainer.h

index df0277fbf60d979fea60d330cc5f844955a4fade..9ad16bb087ce2280f03eb022db301857ef0f96f5 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainer.h

+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.h

@@ -87,7 +87,7 @@ public:

private:

explicit ServiceWorkerContainer(ExecutionContext*);

- typedef ScriptPromiseProperty<ServiceWorkerContainer*, RefPtrWillBeMember<ServiceWorker>, RefPtrWillBeMember<ServiceWorker> > ReadyProperty;

+ typedef ScriptPromiseProperty<RawPtrWillBeMember<ServiceWorkerContainer>, RefPtrWillBeMember<ServiceWorker>, RefPtrWillBeMember<ServiceWorker> > ReadyProperty;

PassRefPtrWillBeRawPtr<ReadyProperty> createReadyProperty();

void checkReadyChanged(PassRefPtrWillBeRawPtr<ServiceWorker> previousReadyWorker);

« no previous file with comments | « Source/bindings/core/v8/ScriptPromisePropertyTest.cpp ('k') | no next file » | no next file with comments »