Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.h

Issue 393773004: Oilpan: improve ScriptPromiseProperty's argument types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove type-driven tracing changes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPromisePropertyTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/ServiceWorkerContainer.h
diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.h b/Source/modules/serviceworkers/ServiceWorkerContainer.h
index df0277fbf60d979fea60d330cc5f844955a4fade..c8b52e718e926d92d42c71452540a6b288235e91 100644
--- a/Source/modules/serviceworkers/ServiceWorkerContainer.h
+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.h
@@ -87,7 +87,7 @@ public:
private:
explicit ServiceWorkerContainer(ExecutionContext*);
- typedef ScriptPromiseProperty<ServiceWorkerContainer*, RefPtrWillBeMember<ServiceWorker>, RefPtrWillBeMember<ServiceWorker> > ReadyProperty;
+ typedef ScriptPromiseProperty<RefPtrWillBeMember<ServiceWorkerContainer>, RefPtrWillBeMember<ServiceWorker>, RefPtrWillBeMember<ServiceWorker> > ReadyProperty;
Mads Ager (chromium) 2014/07/16 11:10:43 It looks to me like this will leak through the tin
sof 2014/07/16 11:30:03 Ouch, a ref pointing straight back. Thanks much, f
PassRefPtrWillBeRawPtr<ReadyProperty> createReadyProperty();
void checkReadyChanged(PassRefPtrWillBeRawPtr<ServiceWorker> previousReadyWorker);
« no previous file with comments | « Source/bindings/core/v8/ScriptPromisePropertyTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698