DescriptionMacViews: Refactor ShowConfirmBubble to also take a gfx::NativeWindow
Currently there's a view/window type mismatch that Aura excuses because
they are the same type (aura::Window*). This doesn't work on MacViews.
For toolkit-views, CreateBrowserModalDialogViews(..) actually takes a
gfx::NativeWindow. However, for Cocoa, the confirm bubble is added as a
subview of the render view.
This changes chrome::ShowConfirmBubble() to accept both a NativeView and
a NativeWindow. Views ignores the view and Cocoa ignores the window but
it allows a toolkit-views build on Mac to call the Cocoa implementation
which is what we need to get started.
BUG=390755
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283373
Patch Set 1 : failed attempt at switching to NativeView->NativeWindow #Patch Set 2 : fix compile.. but changes :/ #Patch Set 3 : new approach: extra argument #
Messages
Total messages: 7 (0 generated)
|