Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 393763002: MacViews: Refactor ShowConfirmBubble to also take a gfx::NativeWindow (Closed)

Created:
6 years, 5 months ago by tapted
Modified:
6 years, 5 months ago
Reviewers:
msw, lazyboy
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Refactor ShowConfirmBubble to also take a gfx::NativeWindow Currently there's a view/window type mismatch that Aura excuses because they are the same type (aura::Window*). This doesn't work on MacViews. For toolkit-views, CreateBrowserModalDialogViews(..) actually takes a gfx::NativeWindow. However, for Cocoa, the confirm bubble is added as a subview of the render view. This changes chrome::ShowConfirmBubble() to accept both a NativeView and a NativeWindow. Views ignores the view and Cocoa ignores the window but it allows a toolkit-views build on Mac to call the Cocoa implementation which is what we need to get started. BUG=390755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283373

Patch Set 1 : failed attempt at switching to NativeView->NativeWindow #

Patch Set 2 : fix compile.. but changes :/ #

Patch Set 3 : new approach: extra argument #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 1 2 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm View 1 2 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/confirm_bubble.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/confirm_bubble_views.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tapted
msw: please review - the second call changes slightly, but I think this is the ...
6 years, 5 months ago (2014-07-15 11:37:51 UTC) #1
lazyboy
lgtm render_view_context_menu/* LGTM
6 years, 5 months ago (2014-07-15 19:08:34 UTC) #2
msw
lgtm
6 years, 5 months ago (2014-07-15 22:44:16 UTC) #3
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 5 months ago (2014-07-15 22:46:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/393763002/60001
6 years, 5 months ago (2014-07-15 22:50:22 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 04:42:26 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 06:07:18 UTC) #7
Message was sent while issue was closed.
Change committed as 283373

Powered by Google App Engine
This is Rietveld 408576698