Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 393733002: [Android] Check for Java object types covariance in Java Bridge (Closed)

Created:
6 years, 5 months ago by mnaganov (inactive)
Modified:
6 years, 5 months ago
Reviewers:
benm (inactive), Torne
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[Android] Check for Java object types covariance in Java Bridge ART does check covariance of types passed via JNI anyway, causing the VM to crash if they doesn't. We'd better check this in Java Bridge and throw a JavaScript exception, as LiveConnect spec suggests. BUG=392489 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283457

Patch Set 1 #

Patch Set 2 : Updated findbugs_known_bugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -105 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/java/gin_java_method_invocation_helper.cc View 1 chunk +17 lines, -7 lines 0 comments Download
M content/browser/android/java/gin_java_script_to_java_types_coercion.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/android/java/gin_java_script_to_java_types_coercion.cc View 17 chunks +67 lines, -28 lines 0 comments Download
M content/browser/android/java/java_method.cc View 4 chunks +6 lines, -39 lines 0 comments Download
M content/browser/android/java/java_type.h View 3 chunks +8 lines, -1 line 0 comments Download
M content/browser/android/java/java_type.cc View 4 chunks +73 lines, -22 lines 0 comments Download
A content/browser/android/java/java_type_unittest.cc View 1 chunk +87 lines, -0 lines 0 comments Download
M content/common/android/gin_java_bridge_errors.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/android/gin_java_bridge_errors.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java View 2 chunks +31 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
mnaganov (inactive)
6 years, 5 months ago (2014-07-15 00:46:57 UTC) #1
Torne
lgtm
6 years, 5 months ago (2014-07-15 21:36:42 UTC) #2
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 5 months ago (2014-07-15 21:48:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/393733002/1
6 years, 5 months ago (2014-07-15 21:51:06 UTC) #4
mnaganov (inactive)
The CQ bit was unchecked by mnaganov@chromium.org
6 years, 5 months ago (2014-07-15 22:53:51 UTC) #5
mnaganov (inactive)
Ben, please take a look! I need OWNER's approval.
6 years, 5 months ago (2014-07-15 22:54:20 UTC) #6
benm (inactive)
lgtm
6 years, 5 months ago (2014-07-15 23:58:16 UTC) #7
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 5 months ago (2014-07-15 23:59:08 UTC) #8
mnaganov (inactive)
The CQ bit was unchecked by mnaganov@chromium.org
6 years, 5 months ago (2014-07-15 23:59:24 UTC) #9
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 5 months ago (2014-07-16 00:03:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/393733002/20001
6 years, 5 months ago (2014-07-16 00:06:51 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 08:12:05 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 08:32:47 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171210)
6 years, 5 months ago (2014-07-16 08:32:48 UTC) #14
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 5 months ago (2014-07-16 15:04:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/393733002/20001
6 years, 5 months ago (2014-07-16 15:07:30 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:54:49 UTC) #17
Message was sent while issue was closed. 
Change committed as 283457

Powered by Google App Engine
This is Rietveld 408576698