Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 393703002: Rename *Fake to Fake* (Closed)

Created:
6 years, 5 months ago by Sergey Ulanov
Modified:
6 years, 5 months ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename *Fake to Fake* Normally fake interface implementations use Fake prefix, but there were some with Fake suffix, namely SignalStrategyFake and HostStatusMonitorFake. Renamed them to use Fake prefix. R=rmsousa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283925

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -305 lines) Patch
M remoting/host/chromoting_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + remoting/host/fake_host_status_monitor.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + remoting/host/fake_screen_capturer.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + remoting/host/fake_screen_capturer.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M remoting/host/host_status_logger_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D remoting/host/host_status_monitor_fake.h View 1 chunk +0 lines, -27 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D remoting/host/screen_capturer_fake.h View 1 chunk +0 lines, -62 lines 0 comments Download
D remoting/host/screen_capturer_fake.cc View 1 chunk +0 lines, -138 lines 0 comments Download
M remoting/host/shaped_screen_capturer_unittest.cc View 1 2 2 chunks +1 line, -32 lines 0 comments Download
M remoting/host/video_scheduler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Sergey Ulanov
6 years, 5 months ago (2014-07-14 23:00:40 UTC) #1
Sergey Ulanov
Renato: ping
6 years, 5 months ago (2014-07-16 18:50:13 UTC) #2
rmsousa
lgtm
6 years, 5 months ago (2014-07-16 20:48:02 UTC) #3
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-16 21:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/393703002/20001
6 years, 5 months ago (2014-07-16 21:18:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 22:27:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 22:45:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/93304) android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/23101) android_clang_dbg ...
6 years, 5 months ago (2014-07-16 22:45:06 UTC) #8
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-17 01:09:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/393703002/20001
6 years, 5 months ago (2014-07-17 01:11:34 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 03:45:41 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 03:51:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/93423) android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/23200) android_clang_dbg ...
6 years, 5 months ago (2014-07-17 03:51:13 UTC) #13
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-17 17:34:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/393703002/20001
6 years, 5 months ago (2014-07-17 17:37:18 UTC) #15
Sergey Ulanov
The CQ bit was unchecked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-17 19:05:23 UTC) #16
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-17 19:28:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/393703002/40001
6 years, 5 months ago (2014-07-17 19:29:33 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 23:21:16 UTC) #19
Sergey Ulanov
Committed patchset #3 manually as r283925 (presubmit successful).
6 years, 5 months ago (2014-07-17 23:42:53 UTC) #20
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 23:44:39 UTC) #21
Message was sent while issue was closed. 
Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

Powered by Google App Engine
This is Rietveld 408576698