Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 393673003: Revert "Enforce clearing renderers' paint invalidation state" (Closed)

Created:
6 years, 5 months ago by falken
Modified:
6 years, 5 months ago
CC:
blink-reviews, cbiesinger, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Revert "Enforce clearing renderers' paint invalidation state" Reason: The following Linux Chrome OS browsertests hit the assert: GalleryBrowserTest.CropImageOnDrive GalleryBrowserTest.DeleteImageOnDownloads GalleryBrowserTest.RenameImageOnDrive GalleryBrowserTest.RotateImageOnDownloads GalleryBrowserTestInGuestMode.ExposureImageOnDownloads Link: http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/248 Excerpt from log: SHOULD NEVER BE REACHED ../../third_party/WebKit/Source/core/rendering/RenderObject.h(253) : void WebCore::RenderObject::assertRendererClearedPaintInvalidationState() const This reverts r178089 (real patch), r178102 (adds autobaseline), r178119 (ARB 1), r178114 (ARB 2) BUG=385169 TBR=jchaffraix NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -155 lines) Patch
M LayoutTests/compositing/repaint/resize-repaint-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint-column-reverse-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/fast/box-shadow/negative-shadow-box-expand-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/box-shadow/negative-shadow-box-shrink-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/repaint/add-table-overpaint-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/box-shadow-inset-repaint-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/repaint/bugzilla-6278-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/content-into-overflow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/make-children-non-inline-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/outline-change-invalidation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/overflow-into-content-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/repaint-table-row-in-composited-document-expected.txt View 1 chunk +5 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/table-row-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/table-section-repaint-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/table-shrink-row-repaint-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/transform-disable-layoutstate-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/block-no-inflow-children-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/bugzilla-5699-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/bugzilla-6278-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/make-children-non-inline-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/outline-change-invalidation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/selection-clear-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/stacked-diacritics-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/table-collapsed-border-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/table-shrink-row-repaint-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/use-setAttribute-crash-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/repaint/block-no-inflow-children-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/repaint/bugzilla-5699-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/platform/mac/fast/repaint/selection-clear-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/repaint/table-collapsed-border-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/mac/svg/custom/use-setAttribute-crash-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/block-no-inflow-children-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/bugzilla-5699-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/bugzilla-6278-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/make-children-non-inline-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/outline-change-invalidation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/selection-clear-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/stacked-diacritics-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/table-collapsed-border-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/table-shrink-row-repaint-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/platform/win-xp/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/svg/custom/use-setAttribute-crash-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/block-no-inflow-children-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/fast/repaint/bugzilla-5699-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/selection-clear-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/fast/repaint/stacked-diacritics-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/fast/repaint/table-collapsed-border-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/use-setAttribute-crash-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 5 chunks +6 lines, -46 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
6 years, 5 months ago (2014-07-15 02:06:00 UTC) #1
falken
The CQ bit was checked by falken@chromium.org
6 years, 5 months ago (2014-07-15 02:06:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/393673003/1
6 years, 5 months ago (2014-07-15 02:07:26 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 02:09:37 UTC) #4
Message was sent while issue was closed. 
Change committed as 178120

Powered by Google App Engine
This is Rietveld 408576698